eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-06 00:10:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix debug message printing LUKS2 checksum.

Browse Source 
The trailing NUL is written already by snprintf, moreover,
it is written on wrong place here.

Just rely on snprintf here.

Fixes: #685.
This commit is contained in:
Milan Broz
2021-11-09 15:29:49 +01:00
parent 26a3f3b058
commit 0cc5f2fdf9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/luks2/luks2_disk_metadata.c
View File

@@ -62,8 +62,8 @@ static void log_dbg_checksum(struct crypt_device *cd,
int i; int i;
for (i = 0; i < crypt_hash_size(csum_alg); i++) for (i = 0; i < crypt_hash_size(csum_alg); i++)
snprintf(&csum_txt[i*2], 3, "%02hhx", (const char)csum[i]); if (snprintf(&csum_txt[i*2], 3, "%02hhx", (const char)csum[i]) != 2)
csum_txt[i*2+1] = '\0'; /* Just to be safe, sprintf should write \0 there. */ return;
log_dbg(cd, "Checksum:%s (%s)", &csum_txt[0], info); log_dbg(cd, "Checksum:%s (%s)", &csum_txt[0], info);
} }