eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-16 21:29:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

lib: fix memory leak in crypt_pbkdf_check

Browse Source 
There is a memory leak when PBKDF2_temp > UINT32_MAX. Here,
we change return to goto out to free key.

Signed-off-by: Lixiaokeng <lixiaokeng@huawei.com>
Signed-off-by: Linfeilong <linfeilong@huawei.com>
This commit is contained in:
lixiaokeng
2020-11-09 09:52:32 +08:00
committed by Milan Broz
parent 78f33946f1
commit 1bc6caceb1
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/crypto_backend/pbkdf_check.c
View File

@@ -361,8 +361,10 @@ static int crypt_pbkdf_check(const char *kdf, const char *hash,
ms = time_ms(&rstart, &rend); ms = time_ms(&rstart, &rend);
if (ms) { if (ms) {
PBKDF2_temp = (double)iterations * target_ms / ms; PBKDF2_temp = (double)iterations * target_ms / ms;
if (PBKDF2_temp > UINT32_MAX) if (PBKDF2_temp > UINT32_MAX) {
return -EINVAL; r = -EINVAL;
goto out;
}
*iter_secs = (uint32_t)PBKDF2_temp; *iter_secs = (uint32_t)PBKDF2_temp;
} }