Avoid if (not NULL) free().

This fixes some COdeQL warnings.
This commit is contained in:
Milan Broz
2025-01-16 15:54:09 +01:00
parent 8364178b38
commit 36574dd114
4 changed files with 9 additions and 19 deletions

View File

@@ -375,9 +375,7 @@ void BITLK_bitlk_vmk_free(struct bitlk_vmk *vmk)
struct bitlk_vmk *vmk_next = NULL;
while (vmk) {
if (vmk->guid)
free(vmk->guid);
if (vmk->name)
free(vmk->name);
crypt_free_volume_key(vmk->vk);
vmk_next = vmk->next;
@@ -392,7 +390,6 @@ void BITLK_bitlk_metadata_free(struct bitlk_metadata *metadata)
return;
free(metadata->guid);
if (metadata->description)
free(metadata->description);
BITLK_bitlk_vmk_free(metadata->vmks);
BITLK_bitlk_fvek_free(metadata->fvek);
@@ -717,9 +714,7 @@ int BITLK_read_sb(struct crypt_device *cd, struct bitlk_metadata *params)
start += entry_size;
}
out:
if (fve_entries)
free(fve_entries);
return r;
}

View File

@@ -356,12 +356,9 @@ static int fill_memory_blocks_mt(argon2_instance_t *instance) {
}
fail:
if (thread != NULL) {
free(thread);
}
if (thr_data != NULL) {
free(thr_data);
}
return rc;
}

View File

@@ -363,7 +363,6 @@ key_serial_t keyring_find_key_id_by_name(const char *key_name)
id = 0;
out:
if (name_copy)
free(name_copy);
return id;

View File

@@ -286,7 +286,6 @@ static int action_resize(void)
}
}
out:
if (backing_file)
free(backing_file);
crypt_free(cd);
return r;