diff --git a/lib/luks2/luks2_reencrypt.c b/lib/luks2/luks2_reencrypt.c index 63b9ae59..7b9d14e6 100644 --- a/lib/luks2/luks2_reencrypt.c +++ b/lib/luks2/luks2_reencrypt.c @@ -2790,7 +2790,7 @@ static int reencrypt_load_by_passphrase(struct crypt_device *cd, struct luks2_reencrypt *rh; const struct volume_key *vk; size_t alignment; - uint32_t old_ss, new_ss, sector_size; + uint32_t old_sector_size, new_sector_size, sector_size; struct crypt_dm_active_device dmd_target, dmd_source = { .uuid = crypt_get_uuid(cd), .flags = CRYPT_ACTIVATE_SHARED /* turn off exclusive open checks */ @@ -2809,9 +2809,9 @@ static int reencrypt_load_by_passphrase(struct crypt_device *cd, log_dbg(cd, "Loading LUKS2 reencryption context."); - old_ss = reencrypt_get_sector_size_old(hdr); - new_ss = reencrypt_get_sector_size_new(hdr); - sector_size = new_ss > old_ss ? new_ss : old_ss; + old_sector_size = reencrypt_get_sector_size_old(hdr); + new_sector_size = reencrypt_get_sector_size_new(hdr); + sector_size = new_sector_size > old_sector_size ? new_sector_size : old_sector_size; r = reencrypt_verify_resilience_params(cd, params, sector_size); if (r < 0) @@ -2918,8 +2918,8 @@ static int reencrypt_load_by_passphrase(struct crypt_device *cd, if ((minimal_size && (required_size < minimal_size)) || (required_size > (device_size >> SECTOR_SHIFT)) || (!dynamic && (required_size != minimal_size)) || - (old_ss > 0 && MISALIGNED(required_size, old_ss >> SECTOR_SHIFT)) || - (new_ss > 0 && MISALIGNED(required_size, new_ss >> SECTOR_SHIFT))) { + (old_sector_size > 0 && MISALIGNED(required_size, old_sector_size >> SECTOR_SHIFT)) || + (new_sector_size > 0 && MISALIGNED(required_size, new_sector_size >> SECTOR_SHIFT))) { log_err(cd, _("Illegal device size requested in reencryption parameters.")); goto err; } diff --git a/tests/luks2-reencryption-test b/tests/luks2-reencryption-test index 21631d12..6ebd108e 100755 --- a/tests/luks2-reencryption-test +++ b/tests/luks2-reencryption-test @@ -1365,26 +1365,26 @@ fi echo "[16] Offline reencryption with fixed device size." preparebig 68 -for test_ss in $TEST_SECTORS; do -printf "sector size %4s: " $test_ss +for test_sector_size in $TEST_SECTORS; do +printf "sector size %4s: " $test_sector_size for test_res in checksum journal none; do echo -n "[$test_res]" - reencrypt_offline_fixed_size $test_ss 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 - reencrypt_offline_fixed_size $test_ss $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 - reencrypt_offline_fixed_size $test_ss $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 + reencrypt_offline_fixed_size $test_sector_size 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 + reencrypt_offline_fixed_size $test_sector_size $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 + reencrypt_offline_fixed_size $test_sector_size $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 echo -n "[OK]" done echo "" done echo "[17] Online reencryption with fixed device size." -for test_ss in $TEST_SECTORS; do -printf "sector size %4s: " $test_ss +for test_sector_size in $TEST_SECTORS; do +printf "sector size %4s: " $test_sector_size for test_res in checksum journal none; do echo -n "[$test_res]" - reencrypt_online_fixed_size $test_ss 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 - reencrypt_online_fixed_size $test_ss $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 - reencrypt_online_fixed_size $test_ss $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 + reencrypt_online_fixed_size $test_sector_size 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 + reencrypt_online_fixed_size $test_sector_size $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 + reencrypt_online_fixed_size $test_sector_size $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 echo -n "[OK]" done echo "" @@ -1393,39 +1393,39 @@ done echo "[18] Offline reencryption with fixed device size (detached header)." preparebig 60 -for test_ss in $TEST_SECTORS; do -printf "sector size %4s: " $test_ss +for test_sector_size in $TEST_SECTORS; do +printf "sector size %4s: " $test_sector_size for test_res in checksum journal none; do echo -n "[$test_res]" - reencrypt_offline_fixed_size $test_ss 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 $IMG_HDR - reencrypt_offline_fixed_size $test_ss $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 $IMG_HDR - reencrypt_offline_fixed_size $test_ss $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + reencrypt_offline_fixed_size $test_sector_size 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + reencrypt_offline_fixed_size $test_sector_size $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + reencrypt_offline_fixed_size $test_sector_size $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 $IMG_HDR echo -n "[OK]" done echo "" done echo "[19] Online reencryption with fixed device size (detached header)." -for test_ss in $TEST_SECTORS; do -printf "sector size %4s: " $test_ss +for test_sector_size in $TEST_SECTORS; do +printf "sector size %4s: " $test_sector_size for test_res in checksum journal none; do echo -n "[$test_res]" - reencrypt_online_fixed_size $test_ss 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 $IMG_HDR - reencrypt_online_fixed_size $test_ss $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 $IMG_HDR - reencrypt_online_fixed_size $test_ss $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + reencrypt_online_fixed_size $test_sector_size 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + reencrypt_online_fixed_size $test_sector_size $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + reencrypt_online_fixed_size $test_sector_size $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 $IMG_HDR echo -n "[OK]" done echo "" done echo "[20] Offline encryption with fixed device size (detached header)." -for test_ss in $TEST_SECTORS; do -printf "sector size %4s: " $test_ss +for test_sector_size in $TEST_SECTORS; do +printf "sector size %4s: " $test_sector_size for test_res in checksum journal none; do echo -n "[$test_res]" - encrypt_offline_fixed_size $test_ss 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 $IMG_HDR - encrypt_offline_fixed_size $test_ss $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 $IMG_HDR - encrypt_offline_fixed_size $test_ss $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + encrypt_offline_fixed_size $test_sector_size 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + encrypt_offline_fixed_size $test_sector_size $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + encrypt_offline_fixed_size $test_sector_size $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 $IMG_HDR echo -n "[OK]" done echo "" @@ -1433,13 +1433,13 @@ done echo "[21] Offline decryption with fixed device size (detached header)." prepare_linear_dev 60 -for test_ss in $TEST_SECTORS; do -printf "sector size %4s: " $test_ss +for test_sector_size in $TEST_SECTORS; do +printf "sector size %4s: " $test_sector_size for test_res in checksum journal none; do echo -n "[$test_res]" - decrypt_offline_fixed_size $test_ss 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 $IMG_HDR - decrypt_offline_fixed_size $test_ss $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 $IMG_HDR - decrypt_offline_fixed_size $test_ss $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + decrypt_offline_fixed_size $test_sector_size 2048 $HASH2 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + decrypt_offline_fixed_size $test_sector_size $((28*1024*2)) $HASH1 $test_res $((60*1024*2)) $HASH8 $IMG_HDR + decrypt_offline_fixed_size $test_sector_size $((31*1024*2)) $HASH7 $test_res $((60*1024*2)) $HASH8 $IMG_HDR echo -n "[OK]" done echo ""