eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-16 21:29:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Print warning if some options were ignored for OPAL hw-only encryption.

Browse Source 
As OPAL without sw encryption bupesses dm-crypt, many activation
options are ignored. Print at least message for user here.

Fixes: #920
This commit is contained in:
Milan Broz
2024-11-23 19:10:53 +01:00
parent 609277d957
commit 3acac6f8fc
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/cryptsetup.c
View File

@@ -1534,6 +1534,10 @@ int luksFormat(struct crypt_device **r_cd, char **r_password, size_t *r_password
type = crypt_get_default_type(); type = crypt_get_default_type();
if (isLUKS2(type)) { if (isLUKS2(type)) {
if (ARG_SET(OPT_HW_OPAL_ONLY_ID) && (ARG_SET(OPT_CIPHER_ID) || ARG_SET(OPT_KEY_SIZE_ID))) {
log_err(_("OPAL hw-only encryption does not support --cipher and --key-size, options ignored."));
}
params = &params2; params = &params2;
} else if (isLUKS1(type)) { } else if (isLUKS1(type)) {
params = &params1; params = &params1;
@@ -2055,6 +2059,12 @@ static int action_open_luks(void)
} while ((r == -EPERM || r == -ERANGE) && (--tries > 0)); } while ((r == -EPERM || r == -ERANGE) && (--tries > 0));
} }
out: out:
if (r >= 0 && activated_name && activate_flags & (CRYPT_ACTIVATE_ALLOW_DISCARDS |
CRYPT_ACTIVATE_SAME_CPU_CRYPT | CRYPT_ACTIVATE_SUBMIT_FROM_CRYPT_CPUS|
CRYPT_ACTIVATE_NO_READ_WORKQUEUE | CRYPT_ACTIVATE_NO_WRITE_WORKQUEUE|
CRYPT_ACTIVATE_HIGH_PRIORITY) && crypt_get_hw_encryption_type(cd) == CRYPT_OPAL_HW_ONLY)
log_err(_("Some specified activation parameters were ignored with OPAL hw-only encryption."));
if (r >= 0 && ARG_SET(OPT_PERSISTENT_ID) && if (r >= 0 && ARG_SET(OPT_PERSISTENT_ID) &&
(crypt_get_active_device(cd, activated_name, &cad) || (crypt_get_active_device(cd, activated_name, &cad) ||
crypt_persistent_flags_set(cd, CRYPT_FLAGS_ACTIVATION, cad.flags & activate_flags))) crypt_persistent_flags_set(cd, CRYPT_FLAGS_ACTIVATION, cad.flags & activate_flags)))