From 4309294c2a355a422a8e6abe2bae30f6efdab882 Mon Sep 17 00:00:00 2001 From: Milan Broz Date: Fri, 12 Feb 2021 11:58:18 +0100 Subject: [PATCH] Remove unnecessary goto from cipher kernel wrapper. --- lib/crypto_backend/crypto_cipher_kernel.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/crypto_backend/crypto_cipher_kernel.c b/lib/crypto_backend/crypto_cipher_kernel.c index df231758..6ee2a5a5 100644 --- a/lib/crypto_backend/crypto_cipher_kernel.c +++ b/lib/crypto_backend/crypto_cipher_kernel.c @@ -164,15 +164,14 @@ static int _crypt_cipher_crypt(struct crypt_cipher_kernel *ctx, } len = sendmsg(ctx->opfd, &msg, 0); - if (len != (ssize_t)(in_length)) { + if (len != (ssize_t)(in_length)) r = -EIO; - goto bad; + else { + len = read(ctx->opfd, out, out_length); + if (len != (ssize_t)out_length) + r = -EIO; } - len = read(ctx->opfd, out, out_length); - if (len != (ssize_t)out_length) - r = -EIO; -bad: crypt_backend_memzero(buffer, sizeof(buffer)); return r; }