eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-16 21:29:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak on error path in luksAddKey.

Browse Source
This commit is contained in:
Ondrej Kozina
2025-05-07 15:50:22 +02:00
committed by Milan Broz
parent e48d5b6d19
commit 48683f7316
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/cryptsetup.c
View File

@@ -2249,7 +2249,7 @@ static int action_luksAddKey(void)
{
bool pin_provided = false;
int keyslot_old, keyslot_new, keysize = 0, r = -EINVAL;
char *key = NULL, *password = NULL, *vk_description = NULL;
char *key, *vk_description, *password = NULL;
size_t password_size = 0;
struct crypt_device *cd = NULL;
struct crypt_keyslot_context *p_kc_new = NULL, *kc = NULL, *kc_new = NULL;
@@ -2325,8 +2325,10 @@ static int action_luksAddKey(void)
if (r == -EPERM)
log_err(_("Volume key does not match the volume."));
check_signal(&r);
if (r < 0)
if (r < 0) {
crypt_safe_free(key);
goto out;
}
r = crypt_keyslot_context_init_by_volume_key(cd, key, keysize, &kc);
crypt_safe_free(key);
} else if (ARG_SET(OPT_VOLUME_KEY_KEYRING_ID)) {