eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-16 05:10:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix various coverity issues.

Browse Source 
Mostly INTEGER_OVERFLOW (CWE-190).
This commit is contained in:
Ondrej Kozina
2024-05-02 11:50:45 +02:00
committed by Milan Broz
parent 5fb3a0e854
commit 92a761e32c
8 changed files with 78 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/utils_keyring.c
View File

@@ -158,7 +158,7 @@ static key_serial_t find_key_by_type_and_desc(const char *type, const char *desc
char *newline;
size_t buffer_len = 0;
int n;
ssize_t n;
do {
id = request_key(type, desc, NULL, 0);
@@ -171,7 +171,8 @@ static key_serial_t find_key_by_type_and_desc(const char *type, const char *desc
return 0;
while ((n = read(f, buf + buffer_len, sizeof(buf) - buffer_len - 1)) > 0) {
buffer_len += n;
/* coverity[overflow:FALSE] */
buffer_len += (size_t)n;
buf[buffer_len] = '\0';
newline = strchr(buf, '\n');
while (newline != NULL && buffer_len != 0) {