From a68eb60be910d5fd97fbe9f6f2052a0c8f3085e2 Mon Sep 17 00:00:00 2001 From: Milan Broz Date: Thu, 20 Jan 2022 11:38:20 +0100 Subject: [PATCH] Fix clang warnings for integer comparison. --- src/utils_reencrypt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/utils_reencrypt.c b/src/utils_reencrypt.c index 1b2ff7f8..d08cb570 100644 --- a/src/utils_reencrypt.c +++ b/src/utils_reencrypt.c @@ -201,13 +201,15 @@ static int action_encrypt_luks2(struct crypt_device **cd, const char *data_devic return -ENOTSUP; } - if (!ARG_SET(OPT_HEADER_ID) && ARG_UINT64(OPT_OFFSET_ID) && data_shift && (ARG_UINT64(OPT_OFFSET_ID) > (imaxabs(data_shift) / (2 * SECTOR_SIZE)))) { + if (!ARG_SET(OPT_HEADER_ID) && ARG_UINT64(OPT_OFFSET_ID) && + data_shift && (ARG_UINT64(OPT_OFFSET_ID) > (uint64_t)(imaxabs(data_shift) / (2 * SECTOR_SIZE)))) { log_err(_("Requested data offset must be less than or equal to half of --reduce-device-size parameter.")); return -EINVAL; } /* TODO: ask user to confirm. It's useless to do data device reduction and than use smaller value */ - if (!ARG_SET(OPT_HEADER_ID) && ARG_UINT64(OPT_OFFSET_ID) && data_shift && (ARG_UINT64(OPT_OFFSET_ID) < (imaxabs(data_shift) / (2 * SECTOR_SIZE)))) { + if (!ARG_SET(OPT_HEADER_ID) && ARG_UINT64(OPT_OFFSET_ID) && + data_shift && (ARG_UINT64(OPT_OFFSET_ID) < (uint64_t)(imaxabs(data_shift) / (2 * SECTOR_SIZE)))) { data_shift = -(ARG_UINT64(OPT_OFFSET_ID) * 2 * SECTOR_SIZE); if (data_shift >= 0) return -EINVAL;