eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-20 23:30:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix time of check/use Coverity report in veritysetup.

Browse Source
This commit is contained in:
Milan Broz
2012-12-17 15:50:42 +01:00
parent 1e3ba81613
commit b86c5a93b3
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/veritysetup.c
View File

@@ -78,17 +78,15 @@ static int action_format(int arg)
struct crypt_device *cd = NULL; struct crypt_device *cd = NULL;
struct crypt_params_verity params = {}; struct crypt_params_verity params = {};
uint32_t flags = CRYPT_VERITY_CREATE_HASH; uint32_t flags = CRYPT_VERITY_CREATE_HASH;
struct stat st;
int r; int r;
/* Try to create hash image if doesn't exist */ /* Try to create hash image if doesn't exist */
if (stat(action_argv[1], &st) < 0) { r = open(action_argv[1], O_WRONLY | O_EXCL | O_CREAT, S_IRUSR | S_IWUSR);
log_dbg("Creating hash image %s.", action_argv[1]); if (r < 0 && errno != EEXIST) {
r = open(action_argv[1], O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR); log_err(_("Cannot create hash image %s for writing.\n"), action_argv[1]);
if (r < 0) { return -EINVAL;
log_err(_("Cannot create hash image %s for writing.\n"), action_argv[1]); } else if (r >= 0) {
return -EINVAL; log_dbg("Created hash image %s.", action_argv[1]);
}
close(r); close(r);
} }