From c3972372b11330a0573a203f14487df666f9d5b2 Mon Sep 17 00:00:00 2001 From: Milan Broz Date: Wed, 6 Nov 2024 09:44:52 +0100 Subject: [PATCH] argon2: Avoid unitialized warning in cppcheck Thsi patch avoids this cppcheck warning: Error: CPPCHECK_WARNING (CWE-457): [#def1] cryptsetup-main/lib/crypto_backend/argon2/blake2/blake2b.c:369: warning[uninitvar]: Uninitialized variable: out_buffer It is a false positive, but wiping buffer is cheap a and similar approach is used in other Argon2 implementations (OpenSSL). --- lib/crypto_backend/argon2/blake2/blake2b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/crypto_backend/argon2/blake2/blake2b.c b/lib/crypto_backend/argon2/blake2/blake2b.c index d8f69e8c..66b2df66 100644 --- a/lib/crypto_backend/argon2/blake2/blake2b.c +++ b/lib/crypto_backend/argon2/blake2/blake2b.c @@ -360,7 +360,7 @@ int blake2b_long(void *pout, size_t outlen, const void *in, size_t inlen) { TRY(blake2b_final(&blake_state, out, outlen)); } else { uint32_t toproduce; - uint8_t out_buffer[BLAKE2B_OUTBYTES]; + uint8_t out_buffer[BLAKE2B_OUTBYTES] = {0}; uint8_t in_buffer[BLAKE2B_OUTBYTES]; TRY(blake2b_init(&blake_state, BLAKE2B_OUTBYTES)); TRY(blake2b_update(&blake_state, outlen_bytes, sizeof(outlen_bytes)));