eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-11 19:00:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Opal: Check for bogus logical size also in activation

Browse Source 
For existing devices we only print warning, but the device is
probably completely misconfigured.
This commit is contained in:
Milan Broz
2024-05-27 11:50:47 +02:00
parent c281241544
commit db980ba1c6
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/luks2/hw_opal/hw_opal.c
View File

@@ -41,6 +41,7 @@
#if HAVE_HW_OPAL #if HAVE_HW_OPAL
#include <linux/sed-opal.h> #include <linux/sed-opal.h>
#include <linux/fs.h>
/* Error codes are defined in the specification: /* Error codes are defined in the specification:
* TCG_Storage_Architecture_Core_Spec_v2.01_r1.00 * TCG_Storage_Architecture_Core_Spec_v2.01_r1.00
@@ -290,6 +291,7 @@ static int opal_range_check_attributes_fd(struct crypt_device *cd,
{ {
int r; int r;
struct opal_lr_status *lrs; struct opal_lr_status *lrs;
int device_block_bytes;
uint32_t opal_block_bytes = 0; uint32_t opal_block_bytes = 0;
uint64_t offset, length; uint64_t offset, length;
bool read_locked, write_locked; bool read_locked, write_locked;
@@ -304,6 +306,11 @@ static int opal_range_check_attributes_fd(struct crypt_device *cd,
if (r != OPAL_STATUS_SUCCESS) if (r != OPAL_STATUS_SUCCESS)
return -EINVAL; return -EINVAL;
/* Keep this as warning only */
if (ioctl(fd, BLKSSZGET, &device_block_bytes) < 0 ||
(uint32_t)device_block_bytes != opal_block_bytes)
log_err(cd, _("Bogus OPAL logical block size differs from device block size."));
lrs = crypt_safe_alloc(sizeof(*lrs)); lrs = crypt_safe_alloc(sizeof(*lrs));
if (!lrs) if (!lrs)
return -ENOMEM; return -ENOMEM;