From 2801d5eafe372357ef5e787dc3fb34ab8a8685a5 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Sat, 31 Jan 2026 00:09:17 +0800 Subject: [PATCH] checkasm/hevc_pel: fix typo size[sizes] -> sizes[size] Commit 4d4b301e4a introduced a typo where `size[sizes]` was used instead of `sizes[size]` in 10 places within checkasm_check_pixel_padded calls. Since `sizes` is an array and `size` is the loop index, `size[sizes]` interprets the array pointer as an index, resulting in undefined behavior and causing AddressSanitizer to detect buffer overflows during testing. Signed-off-by: Jun Zhao --- tests/checkasm/hevc_pel.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/checkasm/hevc_pel.c b/tests/checkasm/hevc_pel.c index 9a83613915..7139a5fc3b 100644 --- a/tests/checkasm/hevc_pel.c +++ b/tests/checkasm/hevc_pel.c @@ -110,7 +110,7 @@ static void checkasm_check_hevc_qpel(void) call_new(dstw1, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]); checkasm_check(int16_t, dstw0, MAX_PB_SIZE * sizeof(int16_t), dstw1, MAX_PB_SIZE * sizeof(int16_t), - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dstw1, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]); } } @@ -159,7 +159,7 @@ static void checkasm_check_hevc_qpel_uni(void) sizes[size], i, j, sizes[size]); checkasm_check_pixel_padded(dst0, dst0_stride, dst1, dst1_stride, - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dst1, dst1_stride, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]); @@ -214,7 +214,7 @@ static void checkasm_check_hevc_qpel_uni_w(void) sizes[size], *denom, *wx, *ox, i, j, sizes[size]); checkasm_check_pixel_padded(dst0, dst0_stride, dst1, dst1_stride, - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dst1, dst1_stride, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], *denom, *wx, *ox, i, j, sizes[size]); @@ -271,7 +271,7 @@ static void checkasm_check_hevc_qpel_bi(void) ref1, sizes[size], i, j, sizes[size]); checkasm_check_pixel_padded(dst0, dst0_stride, dst1, dst1_stride, - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dst1, dst1_stride, src1, sizes[size] * SIZEOF_PIXEL, ref1, sizes[size], i, j, sizes[size]); @@ -330,7 +330,7 @@ static void checkasm_check_hevc_qpel_bi_w(void) ref1, sizes[size], *denom, *wx, *wx, *ox, *ox, i, j, sizes[size]); checkasm_check_pixel_padded(dst0, dst0_stride, dst1, dst1_stride, - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dst1, dst1_stride, src1, sizes[size] * SIZEOF_PIXEL, ref1, sizes[size], *denom, *wx, *wx, *ox, *ox, i, j, sizes[size]); @@ -383,7 +383,7 @@ static void checkasm_check_hevc_epel(void) call_new(dstw1, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]); checkasm_check(int16_t, dstw0, MAX_PB_SIZE * sizeof(int16_t), dstw1, MAX_PB_SIZE * sizeof(int16_t), - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dstw1, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]); } } @@ -432,7 +432,7 @@ static void checkasm_check_hevc_epel_uni(void) sizes[size], i, j, sizes[size]); checkasm_check_pixel_padded(dst0, dst0_stride, dst1, dst1_stride, - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dst1, dst1_stride, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], i, j, sizes[size]); @@ -487,7 +487,7 @@ static void checkasm_check_hevc_epel_uni_w(void) sizes[size], *denom, *wx, *ox, i, j, sizes[size]); checkasm_check_pixel_padded(dst0, dst0_stride, dst1, dst1_stride, - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dst1, dst1_stride, src1, sizes[size] * SIZEOF_PIXEL, sizes[size], *denom, *wx, *ox, i, j, sizes[size]); @@ -544,7 +544,7 @@ static void checkasm_check_hevc_epel_bi(void) ref1, sizes[size], i, j, sizes[size]); checkasm_check_pixel_padded(dst0, dst0_stride, dst1, dst1_stride, - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dst1, dst1_stride, src1, sizes[size] * SIZEOF_PIXEL, ref1, sizes[size], i, j, sizes[size]); @@ -603,7 +603,7 @@ static void checkasm_check_hevc_epel_bi_w(void) ref1, sizes[size], *denom, *wx, *wx, *ox, *ox, i, j, sizes[size]); checkasm_check_pixel_padded(dst0, dst0_stride, dst1, dst1_stride, - size[sizes], size[sizes], "dst"); + sizes[size], sizes[size], "dst"); bench_new(dst1, dst1_stride, src1, sizes[size] * SIZEOF_PIXEL, ref1, sizes[size], *denom, *wx, *wx, *ox, *ox, i, j, sizes[size]);