From 504c1ffcd8dd09c40f4eacecb407d5fce423145c Mon Sep 17 00:00:00 2001 From: Marvin Scholz Date: Tue, 13 Aug 2024 20:06:42 +0200 Subject: [PATCH] fftools/ffmpeg: remove useless error check When ret is checked here, it was never assigned anything, making this check useless, as highlighted by Coverity. It seems to be a copy paste mistake given that opt_match_per_stream_str does not return an error code that could be checked and the previous value assigned to ret is already checked above. So just remove this check. Fixes: CID1616292 --- fftools/ffmpeg_mux_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 274bc61689..6e6eda32e7 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -1315,8 +1315,6 @@ static int ost_add(Muxer *mux, const OptionsContext *o, enum AVMediaType type, const char *format = "{fidx} {sidx} {n} {t}"; opt_match_per_stream_str(ost, &o->enc_stats_pre_fmt, oc, st, &format); - if (ret < 0) - goto fail; ret = enc_stats_init(ost, &ost->enc_stats_pre, 1, enc_stats_pre, format); if (ret < 0)