From b67e271bed0ca8fc610d94d25da9d7b487761ba0 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Thu, 19 Sep 2024 22:03:37 +0200 Subject: [PATCH] avcodec/osq: use unsigned for decorrelation Fixes: signed integer overflow: 1205469696 + 1901074655 cannot be represented in type 'int' Fixes: 70773/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-5419594888577024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer (cherry picked from commit e9f588af9530e5e6f9422ffa0d8e8dc8f80a2ae1) Signed-off-by: Michael Niedermayer --- libavcodec/osq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/osq.c b/libavcodec/osq.c index 826b9f1454..6db25a3ffc 100644 --- a/libavcodec/osq.c +++ b/libavcodec/osq.c @@ -341,7 +341,7 @@ static int do_decode(AVCodecContext *avctx, AVFrame *frame, int decorrelate, int if (nb_channels == 2 && ch == 1) { if (decorrelate) - dst[n] += s->decode_buffer[0][OFFSET+n]; + dst[n] += (unsigned)s->decode_buffer[0][OFFSET+n]; } if (downsample)