From 2df3fcbe5635d33aacf25404fc21751171dc0966 Mon Sep 17 00:00:00 2001
From: Simon Repp <simon@fdpl.io>
Date: Mon, 6 Oct 2025 17:04:17 +0200
Subject: [PATCH] Add missing aria labels and aria-hide purely visual elements
 in editor

---
 translations/src/de.rs                 | 1 +
 translations/src/en.rs                 | 1 +
 translations/src/lib.rs                | 1 +
 web/src/endpoints/video/edit_poster.rs | 2 +-
 web/src/endpoints/video/media.rs       | 6 ++++--
 web/src/widgets/layout.rs              | 6 ++++--
 6 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/translations/src/de.rs b/translations/src/de.rs
index 29013fe..a18d62c 100644
--- a/translations/src/de.rs
+++ b/translations/src/de.rs
@@ -350,6 +350,7 @@ impl Translations {
         upload_poster: "Poster hochladen",
         upload_video_or_audio_file: "Video oder Audiodatei hochladen",
         url: "URL",
+        usage_restrictions: "Einsatzbeschränkungen",
         use_a_dedicated_editor_window: "Der Editor läuft in einem eigenen Fenster",
         use_the_editor_in_your_browser: "Der Editor wird über den Browser verwendet",
         version: "Version",
diff --git a/translations/src/en.rs b/translations/src/en.rs
index 83bb4aa..aaeeae7 100644
--- a/translations/src/en.rs
+++ b/translations/src/en.rs
@@ -351,6 +351,7 @@ impl Translations {
         upload_poster: "Upload Poster",
         upload_video_or_audio_file: "Upload video or audio file",
         url: "URL",
+        usage_restrictions: "Usage restrictions",
         use_a_dedicated_editor_window: "Use a dedicated editor window",
         use_the_editor_in_your_browser: "Use the editor in your browser",
         version: "Version",
diff --git a/translations/src/lib.rs b/translations/src/lib.rs
index f62b5b0..2c791a1 100644
--- a/translations/src/lib.rs
+++ b/translations/src/lib.rs
@@ -342,6 +342,7 @@ pub struct Translations {
     pub upload_poster: &'static str,
     pub upload_video_or_audio_file: &'static str,
     pub url: &'static str,
+    pub usage_restrictions: &'static str,
     pub use_a_dedicated_editor_window: &'static str,
     pub use_the_editor_in_your_browser: &'static str,
     pub version: &'static str,
diff --git a/web/src/endpoints/video/edit_poster.rs b/web/src/endpoints/video/edit_poster.rs
index 2a62e00..88e4819 100644
--- a/web/src/endpoints/video/edit_poster.rs
+++ b/web/src/endpoints/video/edit_poster.rs
@@ -127,7 +127,7 @@ pub fn edit_poster_page(
                         --video-aspect: {video_aspect_numeric};
                     }}
                 </style>
-                <div class="poster_preview_outer">
+                <div aria-hidden="true" class="poster_preview_outer">
                     <div class="video_frame_outer">
                         <div class="video_frame"></div>
                         <div class="poster_frame">
diff --git a/web/src/endpoints/video/media.rs b/web/src/endpoints/video/media.rs
index 28305f5..03f901b 100644
--- a/web/src/endpoints/video/media.rs
+++ b/web/src/endpoints/video/media.rs
@@ -202,6 +202,8 @@ pub fn media_page(
     let site = context.get_site();
     let translations = &session_state.language.translations;
 
+    let t_usage_restrictions = translations.usage_restrictions;
+
     let audio_files = if video.audio_files.is_empty() {
         String::new()
     } else {
@@ -333,7 +335,7 @@ pub fn media_page(
                                 <small>{file_name} ({duration})</small>
                                 <form action="{update_usage_url}" method="post">
                                     <input name="file_name" type="hidden" value="{file_name}">
-                                    <select class="usage" name="usage">
+                                    <select aria-label="{t_usage_restrictions}" class="usage" name="usage">
                                         {usage_options}
                                     </select>
                                 </form>
@@ -507,7 +509,7 @@ pub fn media_page(
                                 <small>{file_name} ({r_video_meta})</small>
                                 <form action="{update_usage_url}" method="post">
                                     <input name="file_name" type="hidden" value="{file_name}">
-                                    <select class="usage" name="usage">
+                                    <select aria-label="{t_usage_restrictions}"class="usage" name="usage">
                                         {usage_options}
                                     </select>
                                 </form>
diff --git a/web/src/widgets/layout.rs b/web/src/widgets/layout.rs
index 3087a56..59e334b 100644
--- a/web/src/widgets/layout.rs
+++ b/web/src/widgets/layout.rs
@@ -227,6 +227,8 @@ fn footer(
     let change_language_url = routes::CHANGE_LANGUAGE;
     let change_theme_url = routes::CHANGE_THEME;
 
+    let t_language = translations.language;
+    let t_theme = translations.theme;
     formatdoc!(r#"
         <footer>
             <div>
@@ -234,7 +236,7 @@ fn footer(
                 <form action="{change_language_url}" method="post">
                     <input name="redirect" type="hidden">
                     <div class="form_split even">
-                        <select id="language_code" name="language_code">
+                        <select aria-label="{t_language}" id="language_code" name="language_code">
                             {language_options}
                         </select>
                     </div>
@@ -245,7 +247,7 @@ fn footer(
                 <form action="{change_theme_url}" method="post">
                     <input name="redirect" type="hidden">
                     <div class="form_split even">
-                        <select id="theme_key" name="theme_key">
+                        <select aria-label="{t_theme}" id="theme_key" name="theme_key">
                             {theme_options}
                         </select>
                     </div>