From 257113a948a2b8c2026bc07caffa9445fcde51b8 Mon Sep 17 00:00:00 2001 From: Harsh Khandeparkar <34770591+HarshKhandeparkar@users.noreply.github.com> Date: Sat, 22 Jun 2019 00:41:10 +0530 Subject: [PATCH] Shorten UI code with new `$step` method (#710) * update dist Signed-off-by: tech4GT dist update Revert "dist update" This reverts commit 9ee2a987e8f978961656ae8f71f6e6702bbbd30d. * Merge remote-tracking branch 'upstream/main' into main * add dist * add new func * update itermediate * changes * fix gitignore * use scopeQuery * add mapHtmlTypes test * scopeQuery tests added * try something * change * fix stepui test * Remove double quotes * update new code * refactor to spec --- examples/lib/defaultHtmlStepUi.js | 78 ++++++++++-------- examples/lib/intermediateHtmlStepUi.js | 32 ++++---- examples/lib/scopeQuery.js | 60 ++++++++++++++ package-lock.json | 33 +++----- package.json | 2 +- spec/insertPreview.spec.js | 26 ------ spec/intermediateHtmlStepUi.spec.js | 19 ----- spec/support/jasmine.json | 11 --- spec/urlHash.spec.js | 40 --------- src/modules/NoiseReduction/NoiseReduction.js | 42 +++++----- test/spec/defaultHtmlSequencerUi.spec.js | 42 ---------- test/spec/defaultHtmlStepUi.spec.js | 61 -------------- test/spec/helpers/reporter.js | 8 -- .../ui/spec}/defaultHtmlSequencerUi.spec.js | 4 +- .../ui/spec}/defaultHtmlStepUi.spec.js | 14 +++- {spec => test/ui/spec}/helpers/reporter.js | 0 test/{ => ui}/spec/insertPreview.spec.js | 4 +- .../spec/intermediateHtmlStepUi.spec.js | 4 +- test/ui/spec/mapHtmlTypes.spec.js | 24 ++++++ test/ui/spec/scopeQuery.spec.js | 81 +++++++++++++++++++ test/{ => ui}/spec/support/jasmine.json | 0 test/{ => ui}/spec/urlHash.spec.js | 2 +- 22 files changed, 274 insertions(+), 313 deletions(-) create mode 100644 examples/lib/scopeQuery.js delete mode 100644 spec/insertPreview.spec.js delete mode 100644 spec/intermediateHtmlStepUi.spec.js delete mode 100644 spec/support/jasmine.json delete mode 100644 spec/urlHash.spec.js delete mode 100644 test/spec/defaultHtmlSequencerUi.spec.js delete mode 100644 test/spec/defaultHtmlStepUi.spec.js delete mode 100644 test/spec/helpers/reporter.js rename {spec => test/ui/spec}/defaultHtmlSequencerUi.spec.js (88%) rename {spec => test/ui/spec}/defaultHtmlStepUi.spec.js (80%) rename {spec => test/ui/spec}/helpers/reporter.js (100%) rename test/{ => ui}/spec/insertPreview.spec.js (83%) rename test/{ => ui}/spec/intermediateHtmlStepUi.spec.js (71%) create mode 100644 test/ui/spec/mapHtmlTypes.spec.js create mode 100644 test/ui/spec/scopeQuery.spec.js rename test/{ => ui}/spec/support/jasmine.json (100%) rename test/{ => ui}/spec/urlHash.spec.js (94%) diff --git a/examples/lib/defaultHtmlStepUi.js b/examples/lib/defaultHtmlStepUi.js index e3933987..07cd8c99 100644 --- a/examples/lib/defaultHtmlStepUi.js +++ b/examples/lib/defaultHtmlStepUi.js @@ -8,18 +8,22 @@ // output values, step information. // See documetation for more details. -var intermediateHtmlStepUi = require('./intermediateHtmlStepUi.js'); -var urlHash = require('./urlHash.js'); -var _ = require('lodash'); -var mapHtmlTypes = require('./mapHtmltypes'); +var intermediateHtmlStepUi = require('./intermediateHtmlStepUi.js'), + urlHash = require('./urlHash.js'), + _ = require('lodash'), + mapHtmlTypes = require('./mapHtmltypes'), + scopeQuery = require('./scopeQuery'), + $stepAll, + $step; function DefaultHtmlStepUi(_sequencer, options) { - + options = options || {}; var stepsEl = options.stepsEl || document.querySelector('#steps'); var selectStepSel = options.selectStepSel = options.selectStepSel || '#selectStep'; function onSetup(step, stepOptions) { + if (step.options && step.options.description) step.description = step.options.description; @@ -67,8 +71,12 @@ function DefaultHtmlStepUi(_sequencer, options) { var parser = new DOMParser(); step.ui = parser.parseFromString(step.ui, 'text/html'); step.ui = step.ui.querySelector('div.container-fluid'); - step.linkElements = step.ui.querySelectorAll('a'); - step.imgElement = step.ui.querySelector('a img.img-thumbnail'); + + $step = scopeQuery.scopeSelector(step.ui); + $stepAll = scopeQuery.scopeSelectorAll(step.ui); + + step.linkElements = $stepAll('a'); + step.imgElement = $step('a img.img-thumbnail')[0]; if (_sequencer.modulesInfo().hasOwnProperty(step.name)) { var inputs = _sequencer.modulesInfo(step.name).inputs; @@ -144,12 +152,12 @@ function DefaultHtmlStepUi(_sequencer, options) { html + '\ '; - step.ui.querySelector('div.details').appendChild(div); + $step('div.details').append(div); } - $(step.ui.querySelector('div.panel-footer')).append( + $step('div.panel-footer').append( '
Press apply to see changes
' ); - $(step.ui.querySelector('div.panel-footer')).prepend( + $step('div.panel-footer').prepend( '\