[FIXED] travis test not failing when module test fails (#1550)

* travis test error fix

* Updated PULL_REQUEST template

* code cleanup

* ..

* some minor changes

* some minor changes

* Trying to restrat the build

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Co-authored-by: Rishabh Shukla <42492389+blurry-x-face@users.noreply.github.com>

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,7 +2,7 @@ Fixes #0000  (<=== Replace `0000` with the Issue Number)
 
 Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
 
-* [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `npm test`
+* [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `npm run test-all`
 * [ ] code is in uniquely-named feature branch and has no merge conflicts
 * [ ] PR is descriptively titled
 * [ ] ask `@publiclab/is-reviewers` for help, in a comment below

.travis.yml

@@ -12,6 +12,10 @@ before_script:
   - ./cc-test-reporter before-build
 script:
   - npm test
+  - npm run benchmark
+  - npm run gif-test
+  - grunt tests
+  - npm run core-tests
   - npm run test-ui
   - npm run test-ui-2
   - grunt build

package.json

@@ -5,7 +5,11 @@
   "main": "src/ImageSequencer.js",
   "scripts": {
     "debug": "TEST=true node ./index.js -i ./examples/images/monarch.png -s invert",
-    "test": "TEST=true istanbul cover tape test/core/*.js test/core/ui/user-interface.js test/core/modules/*.js | tap-spec; node test/core/sequencer/benchmark.js | tap-spec; node test/core/gifs/gif-test.js | tap-spec; grunt tests; cat ./output/core-tests.js | tape-run --render=\"tap-spec\"",
+    "test": "TEST=true istanbul cover tape test/core/*.js test/core/ui/user-interface.js test/core/modules/*.js | tap-spec;",
+    "benchmark" : "node test/core/sequencer/benchmark.js | tap-spec;",
+    "gif-test" : "node test/core/gifs/gif-test.js | tap-spec;",
+    "core-tests" : "cat ./output/core-tests.js | tape-run --render=\"tap-spec\"",
+    "test-all": "npm run test && npm run benchmark && npm run gif-test && grunt tests && npm run core-tests",
     "test-ui": "node node_modules/jasmine/bin/jasmine test/ui/spec/*.js",
     "test-ui-2": "node ./node_modules/.bin/jest",
     "setup": "npm i && npm i -g grunt grunt-cli && grunt build $$ npm rebuild --build-from-source",
@@ -113,4 +117,4 @@
   "bin": {
     "sequencer": "./index.js"
   }
-}
+}