eessppeelllloo/image-sequencer
1
0
Fork 0
mirror of https://github.com/publiclab/image-sequencer.git synced 2025-12-13 20:00:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix Average module editing the UI from the source (#1469)

Browse Source 
* Fix Average module editing the UI from the source

* requested changes

* Delete demo.js

* cleanup

Co-authored-by: Harsh Khandeparkar <34770591+HarshKhandeparkar@users.noreply.github.com>
Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
This commit is contained in:
Naman Aggarwal
2020-01-17 00:46:51 +05:30
committed by Jeffrey Warren
parent b0ddea012a
commit 5ae545904d
3 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
examples/demo.js
View File

@@ -31,13 +31,13 @@ window.onload = function () {
}; };
versionManagement.getLatestVersionNumber(function(versionNumber) { versionManagement.getLatestVersionNumber(function(versionNumber) {
console.log("The latest NPM version number for Image Sequencer (from GitHub) is v" + versionNumber); console.log('The latest NPM version number for Image Sequencer (from GitHub) is v' + versionNumber);
}); });
console.log("The local version number for Image Sequencer is v" + versionManagement.getLocalVersionNumber()); console.log('The local version number for Image Sequencer is v' + versionManagement.getLocalVersionNumber());
function displayVersionNumber() { function displayVersionNumber() {
$('#version-number-text').text("Image Sequencer v" + versionManagement.getLocalVersionNumber()); $('#version-number-text').text('Image Sequencer v' + versionManagement.getLocalVersionNumber());
$('#version-number-top-right').text("v" + versionManagement.getLocalVersionNumber()); $('#version-number-top-right').text('v' + versionManagement.getLocalVersionNumber());
} }
displayVersionNumber(); displayVersionNumber();
@@ -349,4 +349,4 @@ window.onload = function () {
} else { } else {
insertPreview.updatePreviews('images/tulips.png', document.querySelector('#addStep')); insertPreview.updatePreviews('images/tulips.png', document.querySelector('#addStep'));
} }
}; };

4
src/modules/Average/Module.js
View File

@@ -42,8 +42,8 @@ module.exports = function Average(options, UI) {
// report back and store average in metadata: // report back and store average in metadata:
options.step.metadata.averages = sum; options.step.metadata.averages = sum;
// TODO: refactor into a new "display()" method as per https://github.com/publiclab/image-sequencer/issues/242 if (options.step.average === undefined) options.step.average = '';
if (options.step.inBrowser && options.step.ui) $(options.step.ui).find('.details').append('<p><b>Averages</b> (r, g, b, a): ' + sum.join(', ') + '</p>'); options.step.average += 'rgba(' + sum.join(', ') + ')';
return pixels; return pixels;
} }

6
src/modules/Average/info.json
View File

@@ -3,5 +3,11 @@
"description": "Average all pixel color", "description": "Average all pixel color",
"inputs": { "inputs": {
}, },
"outputs": {
"average": {
"type": "string",
"desc": "The average value of all the pixels."
}
},
"docs-link":"https://github.com/publiclab/image-sequencer/blob/main/docs/MODULES.md#average-module" "docs-link":"https://github.com/publiclab/image-sequencer/blob/main/docs/MODULES.md#average-module"
} }