From c4df418f7b190d98eabc81faff7698c2eec0262d Mon Sep 17 00:00:00 2001 From: Tats Date: Wed, 17 Feb 2016 18:02:03 -0500 Subject: [PATCH] Fixed potential error in return policy of Media::setUri(). --- Paint.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Paint.cpp b/Paint.cpp index 5cbfa4d..a4c125d 100644 --- a/Paint.cpp +++ b/Paint.cpp @@ -152,9 +152,7 @@ bool Media::setUri(const QString &uri) static QFileIconProvider provider; // Try to load movie. - bool success = false; - success = impl_->loadMovie(uri); - if (! success) + if (!impl_->loadMovie(uri)) { qDebug() << "Cannot load movie " << uri << "." << endl; return false; @@ -204,6 +202,6 @@ bool Media::setUri(const QString &uri) impl_->resetMovie(); // Return success. - return success; + return true; }