From 10aed9c32b60521efc2fa684774d3ef51d8763bb Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Thu, 3 Feb 2022 16:34:28 -0500 Subject: [PATCH] cleaning up weird DetailPanel exception --- app/src/processing/app/contrib/ListPanel.java | 13 +++++++++---- todo.txt | 2 ++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/app/src/processing/app/contrib/ListPanel.java b/app/src/processing/app/contrib/ListPanel.java index 2f7382f89..fc87e0e58 100644 --- a/app/src/processing/app/contrib/ListPanel.java +++ b/app/src/processing/app/contrib/ListPanel.java @@ -336,10 +336,15 @@ implements Scrollable, ContributionListing.ChangeListener { Icon icon = null; label.setFont(ManagerFrame.NORMAL_PLAIN); StatusPanelDetail detail = detailForContrib.get(contribution); -// if (detail == null) { -// System.out.println("no panel for " + contribution.name + " inside " + contributionTab.contribType); -// } - if (detail.updateInProgress || detail.installInProgress) { + + /* + if (detail != null) { + System.err.println("ListPanel.configureStatusColumnLabel() no panel for " + contribution); + return; + } + */ + + if (detail != null && (detail.updateInProgress || detail.installInProgress)) { // Display "loading" icon if download/install in progress icon = downloadingIcon; } else if (contribution.isInstalled()) { diff --git a/todo.txt b/todo.txt index df1ee029e..5fbd9d70d 100755 --- a/todo.txt +++ b/todo.txt @@ -92,6 +92,8 @@ _ batik and ant have both broken the build when old versions were removed contribs +_ ListPanel.configureStatusColumnLabel() getting null DetailPanel objects +_ seems to be out of sync/unavailable data based on more recent contrib changes? _ several "Could not find a matching .properties file" with clocks pdex _ examples window is per-Mode, but that doesn't seem helpful _ just like sketchbook, you can open one from the other