From 260a7cd84dc6d26d50213dbe3aada0c05a991589 Mon Sep 17 00:00:00 2001
From: Stef Tervelde <stef@steftervelde.nl>
Date: Fri, 10 Jan 2025 17:44:19 +0100
Subject: [PATCH] Update pull_request.yml

---
 .github/workflows/pull_request.yml | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
index 53caf7fb9..c3302d2f2 100644
--- a/.github/workflows/pull_request.yml
+++ b/.github/workflows/pull_request.yml
@@ -52,7 +52,9 @@ jobs:
       - name: Setup Ant
         uses: cedx/setup-ant@v3
       - name: Install Certificates for Code Signing
-        if: ${{ matrix.os_prefix == 'macos' }}
+        env:
+          cert_secret: ${{ secrets.CERTIFICATES_P12 }}
+        if: ${{ matrix.os_prefix == 'macos' && secrets.CERTIFICATES_P12 != '' }}
         uses: apple-actions/import-codesign-certs@v3
         with:
           p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
@@ -60,7 +62,7 @@ jobs:
       - name: Build Release
         run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}"
         env:
-          PROCESSING_APP_SIGNING: true
+          PROCESSING_APP_SIGNING: secrets.CERTIFICATES_P12 != ''
       - name: Add artifact
         uses: actions/upload-artifact@v3
         id: upload
@@ -68,10 +70,3 @@ jobs:
           name: processing-${{github.sha}}${{ matrix.os_prefix }}-${{ matrix.arch }}
           path:  ./build/${{ matrix.os_prefix }}/processing-${{github.sha}}-${{ matrix.os_prefix}}-*
           retention-days: 5
-      # TODO: Merge into one comment and fix the link
-      # - uses: mshick/add-pr-comment@v2
-      #   with: 
-      #       message-id: "build-artifact ${{ matrix.os_prefix }} ${{ matrix.arch }}"
-      #       message: |
-      #           Build artifacts for ${{ matrix.os_prefix }} (${{ matrix.arch }}) have been created.
-      #           Download the artifacts [here](${{ steps.upload.outputs.artifact-id }}).