From 2c02fc666166b3943bdaec514362d203bb745676 Mon Sep 17 00:00:00 2001
From: Ben Fry <fry@processing.org>
Date: Tue, 22 Sep 2015 19:15:39 -0400
Subject: [PATCH] better location for update accessors and controllers

---
 .../processing/app/contrib/ContributionTab.java    | 14 ++++++++++++++
 .../processing/app/contrib/UpdateStatusPanel.java  | 14 +++++---------
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/app/src/processing/app/contrib/ContributionTab.java b/app/src/processing/app/contrib/ContributionTab.java
index dd17680d8..9e005bc40 100644
--- a/app/src/processing/app/contrib/ContributionTab.java
+++ b/app/src/processing/app/contrib/ContributionTab.java
@@ -433,4 +433,18 @@ public class ContributionTab extends JPanel {
   public void updateStatusPanel(DetailPanel contributionPanel) {
     statusPanel.update(contributionPanel);
   }
+
+
+  protected void updateAll() {
+    Collection<DetailPanel> collection =
+      contributionListPanel.panelByContribution.values();
+    for (DetailPanel detailPanel : collection) {
+      detailPanel.update();
+    }
+  }
+
+
+  protected boolean hasUpdates() {
+    return contributionListPanel.getRowCount() > 0;
+  }
 }
diff --git a/app/src/processing/app/contrib/UpdateStatusPanel.java b/app/src/processing/app/contrib/UpdateStatusPanel.java
index 6c12d3096..d8aef30e6 100644
--- a/app/src/processing/app/contrib/UpdateStatusPanel.java
+++ b/app/src/processing/app/contrib/UpdateStatusPanel.java
@@ -4,7 +4,6 @@ import java.awt.Color;
 import java.awt.Font;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
-import java.util.Collection;
 
 import javax.swing.GroupLayout;
 import javax.swing.JButton;
@@ -22,14 +21,13 @@ public class UpdateStatusPanel extends StatusPanel {
     updateButton = new JButton("Update All", Toolkit.getLibIconX("manager/update"));
     updateButton.setFont(Toolkit.getSansFont(14, Font.PLAIN));
     updateButton.setHorizontalAlignment(SwingConstants.LEFT);
+    updateButton.setVisible(true);
+    updateButton.setEnabled(false);
+
     updateButton.addActionListener(new ActionListener() {
       @Override
       public void actionPerformed(ActionEvent e) {
-        Collection<DetailPanel> c =
-          contributionTab.contributionListPanel.panelByContribution.values();
-        for (DetailPanel contributionPanel : c) {
-          contributionPanel.update();
-        }
+        contributionTab.updateAll();
       }
     });
     setBackground(new Color(0xebebeb));
@@ -48,11 +46,9 @@ public class UpdateStatusPanel extends StatusPanel {
 
     layout.setVerticalGroup(layout.createParallelGroup()
       .addComponent(updateButton));
-    updateButton.setVisible(true);
-    updateButton.setEnabled(false);
   }
 
   public void update() {
-    updateButton.setEnabled(contributionTab.contributionListPanel.getRowCount() > 0);
+    updateButton.setEnabled(contributionTab.hasUpdates());
   }
 }
\ No newline at end of file