From 42e88355fd74de3c234fd8b94989e236f1092ccc Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Sat, 13 Feb 2016 18:16:41 -0500 Subject: [PATCH] switch to Java 8u74 which fixes JavaFX smoothing bug (#3795) --- build/build.xml | 9 +++++++-- core/src/processing/core/PApplet.java | 6 +++--- core/src/processing/javafx/PSurfaceFX.java | 3 ++- core/todo.txt | 2 ++ todo.txt | 5 +++++ 5 files changed, 19 insertions(+), 6 deletions(-) diff --git a/build/build.xml b/build/build.xml index 0bade17c2..073345de6 100644 --- a/build/build.xml +++ b/build/build.xml @@ -69,9 +69,14 @@ + https://github.com/processing/processing/issues/3795 + https://bugs.openjdk.java.net/browse/JDK-8136495 --> + + + + message="JDK ${jdk.short} required.${line.separator}To build on OS X, you must install Oracle's JDK ${jdk.short} from${line.separator}http://www.oracle.com/technetwork/java/javase/downloads${line.separator}Or... type 'ant download-jdk-macosx' to download it to your Desktop.${line.separator}Note that only ${jdk.short} (not a later or earlier version) will work. ${line.separator}And it must be the JDK, not the JRE. And do not try to defy me again." /> diff --git a/core/src/processing/core/PApplet.java b/core/src/processing/core/PApplet.java index 04330a5e6..1cd75bd41 100644 --- a/core/src/processing/core/PApplet.java +++ b/core/src/processing/core/PApplet.java @@ -11138,9 +11138,9 @@ public class PApplet implements PConstants { /** * ( begin auto-generated from clip.xml ) * - * Limits the rendering to the boundaries of a rectangle defined - * by the parameters. The boundaries are drawn based on the state - * of the imageMode() fuction, either CORNER, CORNERS, or CENTER. + * Limits the rendering to the boundaries of a rectangle defined + * by the parameters. The boundaries are drawn based on the state + * of the imageMode() fuction, either CORNER, CORNERS, or CENTER. * * ( end auto-generated ) * diff --git a/core/src/processing/javafx/PSurfaceFX.java b/core/src/processing/javafx/PSurfaceFX.java index f1572f6c7..29fa59861 100644 --- a/core/src/processing/javafx/PSurfaceFX.java +++ b/core/src/processing/javafx/PSurfaceFX.java @@ -313,7 +313,8 @@ public class PSurfaceFX implements PSurface { // https://github.com/processing/processing/issues/3823 if ((PApplet.platform == PConstants.MACOSX || PApplet.platform == PConstants.LINUX) && - PApplet.javaVersionName.compareTo("1.8.0_60") >= 0) { + PApplet.javaVersionName.compareTo("1.8.0_60") >= 0 && + PApplet.javaVersionName.compareTo("1.8.0_72") < 0) { System.err.println("smooth() disabled for JavaFX with this Java version due to Oracle bug"); System.err.println("https://github.com/processing/processing/issues/3795"); smooth = 0; diff --git a/core/todo.txt b/core/todo.txt index b1fa91ad8..590391f45 100644 --- a/core/todo.txt +++ b/core/todo.txt @@ -3,6 +3,8 @@ X Fix another "Zero length string passed to TextLayout constructor" error X Ambiguity on where to call smooth() X https://github.com/processing/processing/issues/4211 X add additional clarification for Eclipse users +X Flipped Y-axis in JavaFX is now done (JDK bug) +X https://github.com/processing/processing/issues/3795 _ textAlign(CENTER) and pixelDensity(2) aligning incorrectly with Java2D _ https://github.com/processing/processing/issues/4020 diff --git a/todo.txt b/todo.txt index 09000be77..e973019e3 100644 --- a/todo.txt +++ b/todo.txt @@ -1,4 +1,5 @@ 0248 (3.0.2) +X move to Java 8u74, also fixes JavaFX issue contribs X add "full screen" option to the Editor on OS X @@ -33,6 +34,10 @@ X https://github.com/processing/processing/issues/4098 X https://github.com/processing/processing/pull/4103 X message when reference is find out on nothing selected X https://github.com/processing/processing/pull/4296 +X better handling of quotes in command line args +X https://github.com/processing/processing/pull/4145 +X https://github.com/processing/processing/issues/3996 +X https://github.com/processing/processing/issues/4119 jakub X Workaround for JRE bug freezing the PDE during code completion