From 434d8138ccfdf932ce2a24e4a8c848dee2d9eebc Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Thu, 6 Feb 2014 23:31:58 -0500 Subject: [PATCH] remove a handful of warnings --- core/.settings/org.eclipse.jdt.core.prefs | 6 +++++- core/src/processing/core/PGraphicsJava2D.java | 2 +- core/src/processing/data/JSONObject.java | 12 ++++++------ core/src/processing/opengl/PJOGL.java | 2 +- core/todo.txt | 8 ++++++++ 5 files changed, 21 insertions(+), 9 deletions(-) diff --git a/core/.settings/org.eclipse.jdt.core.prefs b/core/.settings/org.eclipse.jdt.core.prefs index 0c08b2e5b..8e54f4641 100644 --- a/core/.settings/org.eclipse.jdt.core.prefs +++ b/core/.settings/org.eclipse.jdt.core.prefs @@ -1,4 +1,5 @@ eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.annotation.inheritNullAnnotations=disabled org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault @@ -47,6 +48,7 @@ org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignor org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonnullParameterAnnotationDropped=warning org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error org.eclipse.jdt.core.compiler.problem.nullReference=warning org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error @@ -67,6 +69,7 @@ org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled +org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled @@ -75,7 +78,7 @@ org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore -org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore +org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled @@ -90,6 +93,7 @@ org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference= org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning +org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning org.eclipse.jdt.core.compiler.source=1.6 diff --git a/core/src/processing/core/PGraphicsJava2D.java b/core/src/processing/core/PGraphicsJava2D.java index 2503d99b1..853f5496a 100644 --- a/core/src/processing/core/PGraphicsJava2D.java +++ b/core/src/processing/core/PGraphicsJava2D.java @@ -2364,7 +2364,7 @@ public class PGraphicsJava2D extends PGraphics { if (primarySurface) { // 'offscreen' will probably be removed in the next release if (useOffscreen) { - raster = ((BufferedImage) offscreen).getRaster(); + raster = offscreen.getRaster(); } else if (image instanceof VolatileImage) { // when possible, we'll try VolatileImage raster = ((VolatileImage) image).getSnapshot().getRaster(); diff --git a/core/src/processing/data/JSONObject.java b/core/src/processing/data/JSONObject.java index 165b099cd..69add3837 100644 --- a/core/src/processing/data/JSONObject.java +++ b/core/src/processing/data/JSONObject.java @@ -1644,10 +1644,10 @@ public class JSONObject { return value.toString(); } if (value instanceof Map) { - return new JSONObject((Map)value).toString(); + return new JSONObject(value).toString(); } if (value instanceof Collection) { - return new JSONArray((Collection)value).toString(); + return new JSONArray(value).toString(); } if (value.getClass().isArray()) { return new JSONArray(value).toString(); @@ -1683,13 +1683,13 @@ public class JSONObject { } if (object instanceof Collection) { - return new JSONArray((Collection)object); + return new JSONArray(object); } if (object.getClass().isArray()) { return new JSONArray(object); } if (object instanceof Map) { - return new JSONObject((Map)object); + return new JSONObject(object); } Package objectPackage = object.getClass().getPackage(); String objectPackageName = objectPackage != null @@ -1732,9 +1732,9 @@ public class JSONObject { } else if (value instanceof JSONArray) { ((JSONArray) value).write(writer, indentFactor, indent); } else if (value instanceof Map) { - new JSONObject((Map) value).write(writer, indentFactor, indent); + new JSONObject(value).write(writer, indentFactor, indent); } else if (value instanceof Collection) { - new JSONArray((Collection) value).write(writer, indentFactor, + new JSONArray(value).write(writer, indentFactor, indent); } else if (value.getClass().isArray()) { new JSONArray(value).write(writer, indentFactor, indent); diff --git a/core/src/processing/opengl/PJOGL.java b/core/src/processing/opengl/PJOGL.java index 4e6b9bc95..e70af60e2 100644 --- a/core/src/processing/opengl/PJOGL.java +++ b/core/src/processing/opengl/PJOGL.java @@ -961,7 +961,7 @@ public class PJOGL extends PGL { InputEvent.ALT_MASK); char keyChar; - if ((int)nativeEvent.getKeyChar() == 0) { + if (nativeEvent.getKeyChar() == 0) { keyChar = PConstants.CODED; } else { keyChar = nativeEvent.getKeyChar(); diff --git a/core/todo.txt b/core/todo.txt index f2bb09811..b7284bee1 100644 --- a/core/todo.txt +++ b/core/todo.txt @@ -6,12 +6,20 @@ X text looks lousy compared to the Apple JVM X mess with rendering hints? (notes in PGraphicsJava2D) X improvements made, but still not amazing.. just at level of Windows/Linux +_ default font fixes +_ https://github.com/processing/processing/issues/2331 +_ https://github.com/processing/processing/pull/2338 + fixed in 2.1 X draw() called again before finishing on OS X (retina issue) X https://github.com/processing/processing/issues/1709 X get() not always setting alpha channel when used with point() X https://github.com/processing/processing/issues/1756 +A depth buffer shouldn't be cleared when depth mask is disabled +A https://github.com/processing/processing/issues/2296 +A set pixels transparent by default in P2D/P3D +A https://github.com/processing/processing/issues/2207 _ saveFrame() with retina render is making black images _ add print() method to other data types (not just IntList)