From 4d0708deae2bcd196b1c669466c742404d7abc49 Mon Sep 17 00:00:00 2001
From: Stef Tervelde <stef@steftervelde.nl>
Date: Sat, 14 Dec 2024 16:28:19 +0100
Subject: [PATCH] Cleanup pull request signing

Contributors do not have access to the repo's secrets
---
 .github/workflows/pull_request.yml | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
index a8d679354..087c40ee5 100644
--- a/.github/workflows/pull_request.yml
+++ b/.github/workflows/pull_request.yml
@@ -52,16 +52,8 @@ jobs:
           architecture: ${{ matrix.arch }}
       - name: Setup Ant
         uses: cedx/setup-ant@v3
-      - name: Install Certificates for Code Signing
-        if: ${{ matrix.os_prefix == 'macos' }}
-        uses: apple-actions/import-codesign-certs@v3
-        with:
-          p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
-          p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
       - name: Build Release
-        run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}"
-        env:
-          PROCESSING_APP_SIGNING: true
+        run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}
       - name: Add artifact
         uses: actions/upload-artifact@v3
         id: upload
@@ -69,10 +61,3 @@ jobs:
           name: processing-${{github.sha}}${{ matrix.os_prefix }}-${{ matrix.arch }}
           path:  ./build/${{ matrix.os_prefix }}/processing-${{github.sha}}-${{ matrix.os_prefix}}-*
           retention-days: 5
-      # TODO: Merge into one comment and fix the link
-      # - uses: mshick/add-pr-comment@v2
-      #   with: 
-      #       message-id: "build-artifact ${{ matrix.os_prefix }} ${{ matrix.arch }}"
-      #       message: |
-      #           Build artifacts for ${{ matrix.os_prefix }} (${{ matrix.arch }}) have been created.
-      #           Download the artifacts [here](${{ steps.upload.outputs.artifact-id }}).