normalize the behavior of remove() in the Dict classes

This commit is contained in:
Ben Fry
2019-01-20 09:52:29 -08:00
parent 5660feee9d
commit 76eeaccedc
5 changed files with 50 additions and 39 deletions

View File

@@ -3,6 +3,7 @@ package processing.data;
import java.io.*;
import java.util.HashMap;
import java.util.Iterator;
import java.util.NoSuchElementException;
import processing.core.PApplet;
@@ -593,19 +594,20 @@ public class IntDict {
*/
public int remove(String key) {
int index = index(key);
if (index != -1) {
removeIndex(index);
if (index == -1) {
throw new NoSuchElementException("'" + key + "' not found");
}
return index;
int value = values[index];
removeIndex(index);
return value;
}
public String removeIndex(int index) {
public int removeIndex(int index) {
if (index < 0 || index >= count) {
throw new ArrayIndexOutOfBoundsException(index);
}
//System.out.println("index is " + which + " and " + keys[which]);
String key = keys[index];
int value = values[index];
indices.remove(keys[index]);
for (int i = index; i < count-1; i++) {
keys[i] = keys[i+1];
@@ -615,7 +617,7 @@ public class IntDict {
count--;
keys[count] = null;
values[count] = 0;
return key;
return value;
}