From 79e9d5ff339fb1ae497639bb82a2440b096e457d Mon Sep 17 00:00:00 2001 From: Jakub Valtar Date: Sun, 8 May 2016 22:00:02 +0200 Subject: [PATCH] PDEX: Remove some unnecessary calls from rename --- java/src/processing/mode/java/pdex/PDEX.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/java/src/processing/mode/java/pdex/PDEX.java b/java/src/processing/mode/java/pdex/PDEX.java index b74a422ab..44cd0bce3 100644 --- a/java/src/processing/mode/java/pdex/PDEX.java +++ b/java/src/processing/mode/java/pdex/PDEX.java @@ -93,12 +93,10 @@ public class PDEX { private Rename rename; private DebugTree debugTree; - private JavaEditor editor; private PreprocessingService pps; public PDEX(JavaEditor editor, PreprocessingService pps) { - this.editor = editor; this.pps = pps; this.enabled = !editor.hasJavaTabs(); @@ -803,8 +801,6 @@ public class PDEX { editor.startCompoundEdit(); - int currentTabIndex = sketch.getCurrentCodeIndex(); - final int currentOffset = editor.getCaretOffset(); mappedNodes.entrySet().forEach(entry -> { int tabIndex = entry.getKey(); SketchCode sketchCode = sketch.getCode(tabIndex); @@ -833,9 +829,15 @@ public class PDEX { sketchCode.setProgram(document.getText(0, document.getLength())); } catch (BadLocationException e) { /* Whatever */ } sketchCode.setModified(true); - editor.repaintHeader(); }); + editor.stopCompoundEdit(); + + editor.repaintHeader(); + + int currentTabIndex = sketch.getCurrentCodeIndex(); + final int currentOffset = editor.getCaretOffset(); + int precedingIntervals = (int) mappedNodes.getOrDefault(currentTabIndex, Collections.emptyList()) .stream() @@ -844,10 +846,8 @@ public class PDEX { int intervalLengthDiff = newName.length() - binding.getName().length(); int offsetDiff = precedingIntervals * intervalLengthDiff; - sketch.setCurrentCode(currentTabIndex); editor.getTextArea().setCaretPosition(currentOffset + offsetDiff); - editor.stopCompoundEdit(); }