From 93598ecdbe8a9e029b4f7ad9c463aab7fd816768 Mon Sep 17 00:00:00 2001 From: Stef Tervelde Date: Mon, 16 Sep 2024 12:12:23 +0200 Subject: [PATCH] Improved instruction clarity --- build/CODESIGNING.md | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/build/CODESIGNING.md b/build/CODESIGNING.md index a960376ff..0230aa215 100644 --- a/build/CODESIGNING.md +++ b/build/CODESIGNING.md @@ -7,40 +7,39 @@ Signing the Processing.app and the included JRE This happens either by running `ant macos-dist` or in the Github actions ## Setup Github Actions -To setup the Github Actions you need to be the Account Holder on your Apple Developer team. +To setup the Github Actions you need to be the role Account Holder on your Apple Developer team. ### Application Signing We start by creating a .p12 file following the tutorial on the CodeSigning Action https://github.com/Apple-Actions/import-codesign-certs -Currently this consists of following this tutorial: +Currently this consists of following this tutorial with one step altered below: https://calvium.com/how-to-make-a-p12-file/ -NOTE: In the create new certificate section, select `Developer ID Application` this allows the certificate to distribute outside the Mac App Store + +In the create new certificate section, select `Developer ID Application` this allows the certificate to distribute outside the Mac App Store Then take the certificate generated by the tutorial above and copy it to your clipboard as ```bash $ base64 -i CertificateFile.p12 | pbcopy ``` -and set the secrets `CERTIFICATES_P12` and `CERTIFICATES_P12_PASSWORD` into the Github Repository. +and set the secrets `CERTIFICATES_P12` and `CERTIFICATES_P12_PASSWORD` into the Github Repository. This will allow the action to sign Processing and the JRE - ### Notarisation To prevent the *this application is not recognised by Mac OS* error we need to setup the Github Action to upload the release to Apple for Notarisation Go to https://developer.apple.com/account to find the team id in the membership details section and apply it to the `PROCESSING_TEAM_ID` secret -Enter your apple id email in the `PROCESSING_APPLE_ID` secret, this account does **not** need to be an account holder, ideally it is not anyone's personal apple id +Enter an apple id email in the `PROCESSING_APPLE_ID` secret, this account does **not** need to have an Account Holder role, ideally it is not anyone's personal apple id as the password to the apple id will be included into the repositories secrets. Follow these instructions https://support.apple.com/en-us/102654 to setup an app-specific password for the apple id and enter that as `PROCESSING_APP_PASSWORD` ### Release Finally create a release to test the signing actions - ## Sign locally - Be on a MacOS computer