From 9f69e7a07076c02be5c411e7e961f6a7926f2d20 Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Sun, 17 Feb 2013 17:46:24 -0500 Subject: [PATCH] move filter to the top of the manager, organize mgr todos --- .../contrib/ContributionManagerDialog.java | 48 ++++++++++--------- todo.txt | 47 +++++++++++------- 2 files changed, 55 insertions(+), 40 deletions(-) diff --git a/app/src/processing/app/contrib/ContributionManagerDialog.java b/app/src/processing/app/contrib/ContributionManagerDialog.java index 2414caebc..99945233b 100644 --- a/app/src/processing/app/contrib/ContributionManagerDialog.java +++ b/app/src/processing/app/contrib/ContributionManagerDialog.java @@ -139,32 +139,36 @@ public class ContributionManagerDialog { c.gridx = 0; c.gridy = 0; - JPanel categorySelector = new JPanel(); - categorySelector.setLayout(new BoxLayout(categorySelector, BoxLayout.X_AXIS)); - pane.add(categorySelector, c); + JPanel filterPanel = new JPanel(); + filterPanel.setLayout(new BoxLayout(filterPanel, BoxLayout.X_AXIS)); + pane.add(filterPanel, c); - categorySelector.add(Box.createHorizontalStrut(6)); + filterPanel.add(Box.createHorizontalStrut(6)); - JLabel categoryLabel = new JLabel("Filter by Category:"); - categorySelector.add(categoryLabel); + JLabel categoryLabel = new JLabel("Category:"); + filterPanel.add(categoryLabel); - categorySelector.add(Box.createHorizontalStrut(5)); + filterPanel.add(Box.createHorizontalStrut(5)); categoryChooser = new JComboBox(); categoryChooser.setMaximumRowCount(20); updateCategoryChooser(); - categorySelector.add(categoryChooser, c); + filterPanel.add(categoryChooser, c); categoryChooser.addItemListener(new ItemListener() { - public void itemStateChanged(ItemEvent e) { category = (String) categoryChooser.getSelectedItem(); if (ContributionManagerDialog.ANY_CATEGORY.equals(category)) { category = null; } - filterLibraries(category, filterField.filters); } }); + + filterPanel.add(Box.createHorizontalStrut(5)); +// filterPanel.add(Box.createHorizontalGlue()); + filterField = new FilterField(); + filterPanel.add(filterField); +// filterPanel.add(Box.createHorizontalGlue()); } { // The scroll area containing the contribution listing and the status bar. @@ -228,17 +232,17 @@ public class ContributionManagerDialog { pane.add(layeredPane, c); } - { // The filter text area - GridBagConstraints c = new GridBagConstraints(); - c.gridx = 0; - c.gridy = 2; - c.gridwidth = 2; - c.weightx = 1; - c.fill = GridBagConstraints.HORIZONTAL; - filterField = new FilterField(); - - pane.add(filterField, c); - } +// { // The filter text area +// GridBagConstraints c = new GridBagConstraints(); +// c.gridx = 0; +// c.gridy = 2; +// c.gridwidth = 2; +// c.weightx = 1; +// c.fill = GridBagConstraints.HORIZONTAL; +// filterField = new FilterField(); +// +// pane.add(filterField, c); +// } dialog.setMinimumSize(new Dimension(450, 400)); } @@ -342,7 +346,7 @@ public class ContributionManagerDialog { class FilterField extends JTextField { - final static String filterHint = "Filter your search..."; + final static String filterHint = "Filter your search... "; boolean showingHint; List filters; diff --git a/todo.txt b/todo.txt index 083a64988..c8b36f527 100644 --- a/todo.txt +++ b/todo.txt @@ -111,32 +111,41 @@ _ make decision about where coloring is stored _ needs to be reset for this release, maybe others 2.0 FINAL / library/tool/mode manager cleanup +X from Casey +X list in the PDE would be updated automatically by querying a web service +X list on the website would be generated using the same web service +X All I would need to do is update web/contrib_generate/sources.conf +X and the rest would happen automatically. + +high _ boogers still being left around _ Add Mode is also reporting that it's a library that contains multiple _ Add Tool is having problems -_ http://code.google.com/p/processing/issues/detail?id=1569 _ https://github.com/processing/processing/issues/1607 +X http://code.google.com/p/processing/issues/detail?id=1569 _ make already installed libraries distinguishable in the list -_ http://code.google.com/p/processing/issues/detail?id=1212 -_ excessive CPU usage of PDE after using library manager -_ http://code.google.com/p/processing/issues/detail?id=1036 -_ confirmed to still be a problem with b5/6 -_ new libraries not picked up when changing sketchbook location +_ https://github.com/processing/processing/issues/1250 +X http://code.google.com/p/processing/issues/detail?id=1212 + +medium _ Contributed modes should show up in mode menu after installation -_ http://code.google.com/p/processing/issues/detail?id=1466 +_ https://github.com/processing/processing/issues/1504 +X http://code.google.com/p/processing/issues/detail?id=1466 _ using "Add Library" requires restart of Processing before lib recognized -_ http://code.google.com/p/processing/issues/detail?id=1387 -_ from Casey -_ list in the PDE would be updated automatically by querying a web service -_ list on the website would be generated using the same web service -_ All I would need to do is update web/contrib_generate/sources.conf -_ and the rest would happen automatically. -_ alternating blue/white backgrounds aren't updated after changing filter -_ remove PdeKeyListener, roll it into the Java InputHandler for JEditTextArea -_ move Java-specific InputHandler to its own subclass -_ ExceptionInitializerError on startup in ContributionListing, line 50 +_ https://github.com/processing/processing/issues/1425 +X http://code.google.com/p/processing/issues/detail?id=1387 +_ new libraries not picked up when changing sketchbook location +_ make sure it can run w/o a network connection +_ or if a bad document comes through, it can recover +_ gracefully recover from proxy problems _ https://github.com/processing/processing/issues/1601 -_ problem is a proxy server requirement +_ alternating blue/white backgrounds aren't updated after changing filter + +low +_ excessive CPU usage of PDE after using library manager +_ confirmed to still be a problem with b5/6 +_ https://github.com/processing/processing/issues/1074 +X http://code.google.com/p/processing/issues/detail?id=1036 2.0 FINAL / new interface @@ -144,6 +153,8 @@ _ most of theme probably moves back into lib _ editor.bgcolor probably moves out of the theme.txt file for the mode _ or should it be a user preference thing _ for that matter, need to decide on how much modes can customize themselves +_ remove PdeKeyListener, roll it into the Java InputHandler for JEditTextArea +_ move Java-specific InputHandler to its own subclass _ setModified() getting called on Windows (probably Linux) for key cmds