From a39f4d72a7e89fc089ac7405385226d55bd71f18 Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Fri, 25 Nov 2022 06:53:23 -0500 Subject: [PATCH] add extra Preferences.save() after chaning theme (fix for #565) --- app/src/processing/app/tools/ThemeSelector.java | 3 +++ todo.txt | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/src/processing/app/tools/ThemeSelector.java b/app/src/processing/app/tools/ThemeSelector.java index b5cb29f29..1b146d02b 100644 --- a/app/src/processing/app/tools/ThemeSelector.java +++ b/app/src/processing/app/tools/ThemeSelector.java @@ -340,6 +340,9 @@ public class ThemeSelector extends JFrame implements Tool { // preference so that subsequent Processing updates load new theme changes. //Util.saveFile(currentSet.get(index), sketchbookFile); Preferences.set("theme", currentSet.getPath(index)); + // On some machines, the theme wasn't getting saved; try an explicit save + // https://github.com/processing/processing4/issues/565 + Preferences.save(); reloadTheme(); } diff --git a/todo.txt b/todo.txt index 8f55c9b54..efb511acc 100755 --- a/todo.txt +++ b/todo.txt @@ -1,13 +1,14 @@ 1288 (4.1?) X bump Java version to 17.0.5 +X theme is not being kept after Processing restart on Windows +X unable to reproduce so just hoping this works +X https://github.com/processing/processing4/issues/565 _ "Show Sketch Folder" for libraries needs to treat the sketch as Untitled _ and with that, switch to another directory _ https://github.com/processing/processing4/issues/548 -_ theme is not being kept after Processing restart on Windows? -_ https://github.com/processing/processing4/issues/565 _ expanded language codes to support traditional Chinese translation _ https://github.com/processing/processing4/issues/600