From a605ff53ba08480856e64938d78d3c6a15d6b018 Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Sun, 20 Jun 2021 13:37:04 -0400 Subject: [PATCH] major change: move JavaFX to its own library --- build/build.xml | 238 +++--------------- build/windows/config.xml | 21 +- .../src/processing/javafx/PGraphicsFX2D.java | 0 .../src/processing/javafx/PSurfaceFX.java | 0 todo.txt | 10 +- 5 files changed, 51 insertions(+), 218 deletions(-) rename {core => java/libraries/javafx}/src/processing/javafx/PGraphicsFX2D.java (100%) rename {core => java/libraries/javafx}/src/processing/javafx/PSurfaceFX.java (100%) diff --git a/build/build.xml b/build/build.xml index c5573a161..f03841b2e 100644 --- a/build/build.xml +++ b/build/build.xml @@ -72,13 +72,6 @@ - - - - - - - @@ -90,25 +83,6 @@ - - - - - - - - @@ -141,9 +115,11 @@ + @@ -157,87 +133,17 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + @@ -271,40 +177,6 @@ path="${jdk.tgz.path}" /> - - - - - - - - - - - - - - - - - - - - - @@ -410,6 +282,7 @@ + @@ -432,6 +305,7 @@ + @@ -586,7 +460,7 @@ - + @@ -689,7 +563,8 @@ - @@ -1059,7 +938,7 @@ - + @@ -1099,9 +978,10 @@ - + + @@ -1178,10 +1059,6 @@ - @@ -1190,11 +1067,12 @@ + - + @@ -1389,34 +1267,7 @@ - - - - - - - - - - - - - - - - - - - - - - + @@ -1479,16 +1330,6 @@ - - - - - @@ -1517,15 +1354,6 @@ - @@ -1534,15 +1362,6 @@ prefix="processing-${version}" /> - - - ======================================================= Processing for Windows was built. Grab the archive from @@ -1663,7 +1482,7 @@ remove the spaces for depth since it should be double dash, but screws up commen - + @@ -1698,13 +1517,13 @@ remove the spaces for depth since it should be double dash, but screws up commen - + - + @@ -1739,13 +1558,13 @@ remove the spaces for depth since it should be double dash, but screws up commen - + - + @@ -1762,6 +1581,9 @@ remove the spaces for depth since it should be double dash, but screws up commen + + + diff --git a/build/windows/config.xml b/build/windows/config.xml index cb4071f10..c41d49347 100755 --- a/build/windows/config.xml +++ b/build/windows/config.xml @@ -23,21 +23,26 @@ lib/ant.jar lib/ant-launcher.jar - core/library/javafx.base.jar - core/library/javafx.controls.jar - core/library/javafx.fxml.jar - core/library/javafx.graphics.jar - core/library/javafx.media.jar - core/library/javafx.swing.jar + + modes/java/libraries/javafx/library/javafx.base.jar + modes/java/libraries/javafx/library/javafx.controls.jar + modes/java/libraries/javafx/library/javafx.fxml.jar + modes/java/libraries/javafx/library/javafx.graphics.jar + modes/java/libraries/javafx/library/javafx.media.jar + modes/java/libraries/javafx/library/javafx.swing.jar java - -Djava.library.path=lib;core/library - --module-path=core/library + + + + -Djava.library.path=lib;modes/java/libraries/javafx/library + --module-path=modes/java/libraries/javafx/library/windows64 diff --git a/core/src/processing/javafx/PGraphicsFX2D.java b/java/libraries/javafx/src/processing/javafx/PGraphicsFX2D.java similarity index 100% rename from core/src/processing/javafx/PGraphicsFX2D.java rename to java/libraries/javafx/src/processing/javafx/PGraphicsFX2D.java diff --git a/core/src/processing/javafx/PSurfaceFX.java b/java/libraries/javafx/src/processing/javafx/PSurfaceFX.java similarity index 100% rename from core/src/processing/javafx/PSurfaceFX.java rename to java/libraries/javafx/src/processing/javafx/PSurfaceFX.java diff --git a/todo.txt b/todo.txt index 3c44206fa..6be11e61e 100755 --- a/todo.txt +++ b/todo.txt @@ -36,10 +36,16 @@ X https://github.com/processing/processing/issues/3288 o these will change again for Java 11, so wait until then X opting not to do so X https://github.com/processing/processing4/issues/210 +X move JavaFX to its own library, too many weird quirks that it includes +o build bits should be in core/build.xml or javafx/build.xml +X by moving it out, all the strangeness of download and import is outside core +_ fix modules path warning for Tools in the PDE +_ update for new modules path when running from the PDE +_ update modules path when exporting application + +_ automatically import JavaFX if FX2D is in sketch? or tell user? -_ move JavaFX to its own library, too many weird quirks that it includes -_ build bits should be in core/build.xml or javafx/build.xml _ Remove usage of com.sun.* in JavaFX library _ https://github.com/processing/processing4/issues/208 _ Only specify --modules-path when running JavaFX apps