From c31c5f3ec6f9ebb33af111d4a1624d4c3b2b783a Mon Sep 17 00:00:00 2001 From: Jakub Valtar Date: Sat, 21 Jan 2017 05:21:05 +0100 Subject: [PATCH] Remove some unnecessary code --- app/src/processing/app/contrib/ListPanel.java | 12 +++++------- app/src/processing/app/contrib/UpdateListPanel.java | 10 ++++------ 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/app/src/processing/app/contrib/ListPanel.java b/app/src/processing/app/contrib/ListPanel.java index 07b03a34d..29b903ffe 100644 --- a/app/src/processing/app/contrib/ListPanel.java +++ b/app/src/processing/app/contrib/ListPanel.java @@ -378,7 +378,7 @@ implements Scrollable, ContributionListing.ChangeListener { } String authorList = contribution.getAuthorList(); String name = getAuthorNameWithoutMarkup(authorList); - label.setText(name.toString()); + label.setText(name); label.setHorizontalAlignment(SwingConstants.LEFT); if(!contribution.isCompatible(Base.getRevision())){ label.setForeground(Color.LIGHT_GRAY); @@ -454,12 +454,10 @@ implements Scrollable, ContributionListing.ChangeListener { new DetailPanel(ListPanel.this); panelByContribution.put(contribution, newPanel); visibleContributions.add(contribution); - if (newPanel != null) { - newPanel.setContribution(contribution); - add(newPanel); - updatePanelOrdering(visibleContributions); - updateColors(); // XXX this is the place - } + newPanel.setContribution(contribution); + add(newPanel); + updatePanelOrdering(visibleContributions); + updateColors(); // XXX this is the place } } } diff --git a/app/src/processing/app/contrib/UpdateListPanel.java b/app/src/processing/app/contrib/UpdateListPanel.java index aea0442d9..47939a3ce 100644 --- a/app/src/processing/app/contrib/UpdateListPanel.java +++ b/app/src/processing/app/contrib/UpdateListPanel.java @@ -233,12 +233,10 @@ public class UpdateListPanel extends ListPanel { panelByContribution.put(contribution, newPanel); } visibleContributions.add(contribution); - if (newPanel != null) { - newPanel.setContribution(contribution); - add(newPanel); - updatePanelOrdering(panelByContribution.keySet()); - updateColors(); // XXX this is the place - } + newPanel.setContribution(contribution); + add(newPanel); + updatePanelOrdering(panelByContribution.keySet()); + updateColors(); // XXX this is the place } }