From cdfe575ea20251944bfe92fe49bcacb902383b4e Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Sat, 25 Apr 2015 03:27:51 -0400 Subject: [PATCH] fix for #3113 noSmooth() issues --- core/src/processing/core/PGraphicsJava2D.java | 7 ++++--- core/todo.txt | 6 +++--- todo.txt | 6 ++++++ 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/core/src/processing/core/PGraphicsJava2D.java b/core/src/processing/core/PGraphicsJava2D.java index e08877a48..d8f4f42b1 100644 --- a/core/src/processing/core/PGraphicsJava2D.java +++ b/core/src/processing/core/PGraphicsJava2D.java @@ -1439,9 +1439,9 @@ public class PGraphicsJava2D extends PGraphics { @Override - public void smooth(int antialias) { - this.quality = antialias; - if (antialias == 0) { + public void smooth(int quality) { + this.quality = quality; + if (quality == 0) { noSmooth(); } else { smooth(); @@ -1452,6 +1452,7 @@ public class PGraphicsJava2D extends PGraphics { @Override public void noSmooth() { smooth = false; + quality = 0; // Github 3113 g2.setRenderingHint(RenderingHints.KEY_ANTIALIASING, RenderingHints.VALUE_ANTIALIAS_OFF); g2.setRenderingHint(RenderingHints.KEY_INTERPOLATION, diff --git a/core/todo.txt b/core/todo.txt index 3558c566e..5d4163504 100644 --- a/core/todo.txt +++ b/core/todo.txt @@ -18,13 +18,13 @@ o really nice for auto-complete o prevents hundreds of entries from coming up w/ auto-complete o downside: breaks compatibility big time X would have to use ALIGN_CENTER eta al, so no +X noSmooth() not sticking, has to be called again inside draw() +X https://github.com/processing/processing/issues/3113 showstoppers -_ noSmooth() and other settings reset after setup() -_ https://github.com/processing/processing/issues/3113 _ static mode - no setup() / draw() - broken in OpenGL _ https://github.com/processing/processing/issues/3163 -_ sketch window is not placed at correct location on restart +_ sketch window is not placed at correct location when running a second time _ https://github.com/processing/processing/issues/3125 head diff --git a/todo.txt b/todo.txt index f74747cd6..17cf41b40 100644 --- a/todo.txt +++ b/todo.txt @@ -32,6 +32,12 @@ X auto-insert after antlr @SuppressWarnings({ "unused", "unchecked", "cast" }) X fix file change detection on OS X X https://github.com/processing/processing/issues/2852 +_ Preferences window sizing problems +_ window contents are cropped off +_ Editor font size dropdown is enormous +_ https://github.com/processing/processing/issues/3212 +_ Find/Replace regressions +_ https://github.com/processing/processing/issues/3213 _ editor window draws in stages (at least on OS X) on first view X is debug turned on? lots of "export.txt" complaints _ remove export.txt complaints when loading libraries