From f07d428607d8b70aa7856050f1f81c0e901ac6cb Mon Sep 17 00:00:00 2001 From: Ben Fry Date: Fri, 17 Feb 2023 21:24:16 -0500 Subject: [PATCH] notes about the icon fixes --- .../processing/app/platform/WindowsPlatform.java | 3 ++- todo.txt | 16 +++++++++------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/app/src/processing/app/platform/WindowsPlatform.java b/app/src/processing/app/platform/WindowsPlatform.java index ed6dd31fc..b74a1674c 100644 --- a/app/src/processing/app/platform/WindowsPlatform.java +++ b/app/src/processing/app/platform/WindowsPlatform.java @@ -3,7 +3,7 @@ /* Part of the Processing project - http://processing.org - Copyright (c) 2012-2013 The Processing Foundation + Copyright (c) 2012-2023 The Processing Foundation Copyright (c) 2008-2012 Ben Fry and Casey Reas This program is free software; you can redistribute it and/or @@ -83,6 +83,7 @@ public class WindowsPlatform extends DefaultPlatform { WindowsRegistry.setStringValue(rootKey, "Software\\Classes\\" + doc, "", title) && // Assign an .ico file to this document type + // https://learn.microsoft.com/en-us/windows/win32/shell/how-to-assign-a-custom-icon-to-a-file-type WindowsRegistry.createKey(rootKey, "Software\\Classes\\" + doc, "DefaultIcon") && WindowsRegistry.setStringValue(rootKey, "Software\\Classes\\" + doc + "\\DefaultIcon", "", iconPath) && diff --git a/todo.txt b/todo.txt index 11e234fb9..e821f458b 100755 --- a/todo.txt +++ b/todo.txt @@ -3,16 +3,21 @@ X application exported to the wrong folder X https://github.com/processing/processing4/issues/601 X more /tmp folder problems with Linux (may be the subdirectories?) X https://github.com/processing/processing4/issues/666 -_ add a protocol handler for pdex and pdez -_ https://github.com/processing/processing4/issues/559 +X add a protocol handler for pdex and pdez +X https://github.com/processing/processing4/issues/559 X implemented for macOS +X implemented for Windows X Windows implementation https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=94914f2852f0c32e60361648ec82da153b8d70ae _ https://web.archive.org/web/20210601082308/https://support.shotgunsoftware.com/hc/en-us/articles/219031308-How-to-launch-external-applications-using-custom-protocols-rock-instead-of-http-?mobile_site=true _ presumably from https://github.com/pboucher ? _ check on Linux implementation _ need to also warn people about running 'em - -_ pdez (and presumably pdex) files have the wrong icons on Windows +X implement icon files on Windows +X pdez (and presumably pdex) files have the wrong icons on Windows +X implement document icons for pdez etc on Windows +X icons/earlier +X need .pde document icons +X need .psk file icon python (api changes mean this is 4.2) X move ExportDialog to processing.app.ui (out of Java Mode) so it can be used by Jython @@ -642,8 +647,6 @@ _ drag and drop _ including the number of items added to sketch would be especially nice _ implement automatic update _ https://github.com/processing/processing/issues/100 -_ need .pde document icons -_ need .psk file icon _ need exported application icons _ need more comprehensive list of 'known bugs' _ need more comprehensive list of 'known suggestions' @@ -665,7 +668,6 @@ _ p5 assets need to be licensed differently from the source DIST / Windows -_ implement document icons for pdez etc on Windows _ Resolve “Successfully created” and “illegal reflective access” errors from launch4j _ https://github.com/processing/processing4/issues/137 _ windows batch file would be a good idea (debugging is hard)