diff --git a/app/src/processing/app/contrib/AvailableContribution.java b/app/src/processing/app/contrib/AvailableContribution.java index f228423c0..99d9b09f0 100644 --- a/app/src/processing/app/contrib/AvailableContribution.java +++ b/app/src/processing/app/contrib/AvailableContribution.java @@ -255,22 +255,7 @@ public class AvailableContribution extends Contribution { category = sb.toString(); } - //String specifiedImport = ""; StringList importsList = parseImports(properties); - /* - if (importsList == null || importsList.isEmpty()) { - specifiedImport = getImportStr(); - } else { - StringBuilder sbImport = new StringBuilder(); - for (String it : imports) { - sbImport.append(it); - sbImport.append(','); - } - sbImport.deleteCharAt(sbImport.length() - 1); - specifiedImport = sbImport.toString(); - } - */ - String importItem = importsList.join(","); String authors = properties.get(AUTHORS_PROPERTY); if (authors == null) { @@ -358,8 +343,8 @@ public class AvailableContribution extends Contribution { writer.println("lastUpdated=" + lastUpdated); writer.println("minRevision=" + minRev); writer.println("maxRevision=" + maxRev); - if (getType() == ContributionType.LIBRARY) { - writer.println("imports=" + importItem); + if (getType() == ContributionType.LIBRARY && importsList != null) { + writer.println("imports=" + importsList.join(",")); } if (getType() == ContributionType.EXAMPLES) { writer.println(MODES_PROPERTY + "=" + compatibleContribsList); diff --git a/todo.txt b/todo.txt index e301487ff..1962ea462 100644 --- a/todo.txt +++ b/todo.txt @@ -52,6 +52,10 @@ X finish adding 'examples' contribs X https://github.com/processing/processing/issues/2953 o don't return here, allow contrib types to fail: o https://github.com/processing/processing/blob/master/app/src/processing/app/contrib/ContributionListing.java#L509 +X StatusPanel created for Contribution Manager +X https://github.com/processing/processing/pull/3432 +X Error during installation of any contribution +X https://github.com/processing/processing/issues/3429 cleaning o libraries in java tabs (separate .java files) are reported missing