From a0e8045fb1e051fbfa58cbd85a5e8d023d11e9d8 Mon Sep 17 00:00:00 2001 From: Tristan Rowley Date: Sun, 19 Jan 2020 15:19:04 +0000 Subject: [PATCH] fixes to example plugin ! --- plugins/MidiActionsTestPlugin.py | 8 ++++---- plugins/MidiFeedbackAPCKey25Plugin.py | 8 +++++--- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/plugins/MidiActionsTestPlugin.py b/plugins/MidiActionsTestPlugin.py index bcec862..9c99d9b 100644 --- a/plugins/MidiActionsTestPlugin.py +++ b/plugins/MidiActionsTestPlugin.py @@ -30,10 +30,10 @@ class MidiActionsTestPlugin(ActionsPlugin,SequencePlugin): self.cycle_count = 0 for i,shader in enumerate(self.pc.message_handler.shaders.selected_shader_list): - self.pc.midi_input.call_method_name( + self.pc.actions.call_method_name( "play_shader_%s_%s" % (i, self.cycle_count), None ) - self.pc.midi_input.call_method_name( + self.pc.actions.call_method_name( "start_shader_layer_%s" % i, None ) self.cycle_count += 1 @@ -41,11 +41,11 @@ class MidiActionsTestPlugin(ActionsPlugin,SequencePlugin): duration = 5000 frequency = 50 def run_sequence(self, position): - self.pc.midi_input.call_method_name( + self.pc.actions.call_method_name( "set_the_shader_param_0_layer_0_continuous", position ) - self.pc.midi_input.call_method_name( + self.pc.actions.call_method_name( "set_the_shader_param_1_layer_0_continuous", position ) diff --git a/plugins/MidiFeedbackAPCKey25Plugin.py b/plugins/MidiFeedbackAPCKey25Plugin.py index ba1c1ea..2b85114 100644 --- a/plugins/MidiFeedbackAPCKey25Plugin.py +++ b/plugins/MidiFeedbackAPCKey25Plugin.py @@ -13,7 +13,7 @@ class MidiFeedbackAPCKey25Plugin(MidiFeedbackPlugin): def get_note(self,action,default): bind = self.pc.midi_input.find_binding_for_action(action) - if 'note ' in bind: + if bind and 'note ' in bind: return int(play_bind.split(' ')[1]) else: return default @@ -128,7 +128,8 @@ class MidiFeedbackAPCKey25Plugin(MidiFeedbackPlugin): colour = self.COLOUR_OFF self.set_status(command='note_on', note=self.NOTE_CLIP_STATUS_ROW+i, velocity=colour) except Exception as e: - print ("Warning: Failed when running plugin feedback for ShaderLoopRecordPlugin:\t%s" % str(e)) + pass + #print ("Warning: Failed when running plugin feedback for ShaderLoopRecordPlugin:\t%s" % str(e)) try: from plugins.ShaderQuickPresetPlugin import ShaderQuickPresetPlugin @@ -148,7 +149,8 @@ class MidiFeedbackAPCKey25Plugin(MidiFeedbackPlugin): colour += self.BLINK self.set_status(command='note_on', note=pad, velocity=colour) except Exception as e: - print ("Warning: Failed when running plugin feedback for ShaderQuickPresetPlugin:\t%s" % str(e)) + pass + #print ("Warning: Failed when running plugin feedback for ShaderQuickPresetPlugin:\t%s" % str(e)) BLINK = 1 COLOUR_OFF = 0