eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2026-01-08 16:35:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix open flags in cryptsetup-reencrypt header access check.

Browse Source 
We should not use O_DIRECT, it does not work tin in-memory fs.

Also never use O_EXCL on regular files, it is undedfined according
to open() documentation.

Fixes: #529.
This commit is contained in:
Milan Broz
2020-04-03 12:59:50 +02:00
parent e10724accb
commit 02b3f42500
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/cryptsetup_reencrypt.c
View File

@@ -194,8 +194,14 @@ static int device_check(struct reenc_ctx *rc, const char *device, header_magic s
ssize_t s;
uint16_t version;
size_t buf_size = pagesize();
struct stat st;
devfd = open(device, O_RDWR | O_EXCL | O_DIRECT);
if (stat(device, &st)) {
log_err(_("Cannot open device %s."), device);
return -EINVAL;
}
devfd = open(device, O_RDWR | (S_ISBLK(st.st_mode) ? O_EXCL : 0));
if (devfd == -1) {
if (errno == EBUSY) {
log_err(_("Cannot exclusively open %s, device in use."),