eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-05 16:00:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix integer and double types in keyslot checker.

Browse Source 
To avoid theoretical overflows detected by Coverity.
This commit is contained in:
Milan Broz
2025-05-27 09:03:40 +02:00
parent cf630f578d
commit 19d67d3c62
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/utils_keyslot_check.c
View File

@@ -36,7 +36,7 @@ static double chisquared_bits(void *b, uint64_t count)
{
size_t i;
double f[2] = {0};
double tmp, t = 0, e = count * 8 / ARRAY_SIZE(f);
double tmp, t = 0, e = count * 8 / (double)ARRAY_SIZE(f);
f[1] = bitcount((uint64_t*)b, count / sizeof(uint64_t));
f[0] = (count * 8) - f[1];
@@ -56,7 +56,7 @@ static double chisquared_bytes(unsigned char *N, uint64_t count)
{
size_t i;
double f[256] = {0};
double tmp, t = 0, e = count / ARRAY_SIZE(f);
double tmp, t = 0, e = count / (double)ARRAY_SIZE(f);
for (i = 0; i < count; i++)
f[N[i]]++;
@@ -168,7 +168,7 @@ void luks_check_keyslots(struct crypt_device *cd, const char *device)
* data_length is the really used keyslot area
* length = data_legth + padding_4096
*/
data_length = r * LUKS_STRIPES;
data_length = (uint64_t)r * LUKS_STRIPES;
buffer = malloc(data_length);
if (!buffer)