eessppeelllloo/cryptsetup
1
0
Fork 0
mirror of https://gitlab.com/cryptsetup/cryptsetup.git synced 2025-12-06 00:10:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean reencrypt status struct for API call.

Browse Source 
This function should not return unitialized struct as there
is no indication that it failed and caller can access it.

Also fixes a Coverity warning.
This commit is contained in:
Milan Broz
2022-04-18 10:18:18 +02:00
parent 2857e10083
commit f1eea3a4b3
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/luks2/luks2_reencrypt.c
View File

@@ -3718,6 +3718,9 @@ crypt_reencrypt_info LUKS2_reencrypt_get_params(struct luks2_hdr *hdr,
int digest;
uint32_t version;
if (params)
memset(params, 0, sizeof(*params));
ri = LUKS2_reencrypt_status(hdr);
if (ri == CRYPT_REENCRYPT_NONE || ri == CRYPT_REENCRYPT_INVALID || !params)
return ri;

3
lib/setup.c
View File

@@ -6387,6 +6387,9 @@ void crypt_serialize_unlock(struct crypt_device *cd)
crypt_reencrypt_info crypt_reencrypt_status(struct crypt_device *cd,
struct crypt_params_reencrypt *params)
{
if (params)
memset(params, 0, sizeof(*params));
if (!cd || !isLUKS2(cd->type))
return CRYPT_REENCRYPT_NONE;