Milan Broz 46289f92ff argon2: Avoid cppcheck integer oveflow warning ...

This patch avoid warning in constant-time base64 function:

Error: CPPCHECK_WARNING (CWE-190): [#def2]
cryptsetup-main/lib/crypto_backend/argon2/encoding.c:86: error[integerOverflow]: Signed integer overflow for expression ''0'-52'.

The (x + ('0' - 52)) can be rewritten to (x - (52 - '0')) with the same effect.
Similar solution used in https://github.com/pornin/CTTK/blob/master/src/base64.c

2024-11-08 19:51:14 +00:00

16 KiB

Raw Permalink Blame History

View Raw