mirror of
https://git.ffmpeg.org/ffmpeg.git
synced 2026-06-16 04:32:47 +02:00
avfilter/vf_signature: Fix leak of string upon error
If an error happens between allocating a string intended to be used as
an inpad's name and attaching it to its input pad, the string leaks.
Fix this by inserting the inpad directly after allocating its string.
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
(cherry picked from commit 16ea88778e)
This commit is contained in:
@@ -664,6 +664,10 @@ static av_cold int init(AVFilterContext *ctx)
|
||||
|
||||
if (!pad.name)
|
||||
return AVERROR(ENOMEM);
|
||||
if ((ret = ff_insert_inpad(ctx, i, &pad)) < 0) {
|
||||
av_freep(&pad.name);
|
||||
return ret;
|
||||
}
|
||||
|
||||
sc = &(sic->streamcontexts[i]);
|
||||
|
||||
@@ -680,11 +684,6 @@ static av_cold int init(AVFilterContext *ctx)
|
||||
sc->coarseend = sc->coarsesiglist;
|
||||
sc->coarsecount = 0;
|
||||
sc->midcoarse = 0;
|
||||
|
||||
if ((ret = ff_insert_inpad(ctx, i, &pad)) < 0) {
|
||||
av_freep(&pad.name);
|
||||
return ret;
|
||||
}
|
||||
}
|
||||
|
||||
/* check filename */
|
||||
|
||||
Reference in New Issue
Block a user