mirror of
https://git.ffmpeg.org/ffmpeg.git
synced 2026-02-15 11:45:33 +01:00
e7a629049f
Forgotten in70a7df049c. Using the wrong scantable matters for codecs for which both scantables can differ, namely the MPEG-4 decoder and the WMV1/2 codecs. For WMV1 it can lead to wrong output in case the IDCT permutation is FF_IDCT_PERM_PARTTRANS, because in this case the entries of of the intra scantable's raster end are not always <= the corresponding entries of the inter scantable's raster end when the former is initialized via ff_wmv1_scantable[1] and the latter via ff_wmv1_scantable[0]. FF_IDCT_PERM_PARTTRANS is used iff the Neon IDCT is used (for both arm and aarch64).* Said IDCT is not used during FATE, so that this issue went unnoticed. WMV2 uses the same scantables, but uses a custom IDCT which always uses FF_IDCT_PERM_NONE for which the inter_scantable, so that the output is always correct for it. The scantable for MPEG-4 can change mid-stream (for the decoder), but sincec41818dc5donly the intra scantable is updated, so that both scantables can get out of sync. In such a case the unquantize intra functions could unquantize an incorrect number of coefficients. Using raster_end of the wrong scantable can also lead to an unnecessarily large amount of coefficients unquantized. *: FF_IDCT_PERM_SIMPLE and FF_IDCT_PERM_TRANSPOSE would also not work, but they are not used at all by arm and aarch64. Reviewed-by: Martin Storsjö <martin@martin.st> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
34 lines
1.2 KiB
C
34 lines
1.2 KiB
C
/*
|
|
* Copyright (c) 2010 Mans Rullgard
|
|
*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef AVCODEC_ARM_ASM_OFFSETS_H
|
|
#define AVCODEC_ARM_ASM_OFFSETS_H
|
|
|
|
/* MpegEncContext */
|
|
#define Y_DC_SCALE 0x04
|
|
#define C_DC_SCALE 0x08
|
|
#define AC_PRED 0x0c
|
|
#define BLOCK_LAST_INDEX 0x10
|
|
#define H263_AIC 0x40
|
|
#define INTER_SCANTAB_RASTER_END 0x88
|
|
#define INTRA_SCANTAB_RASTER_END 0x10c
|
|
|
|
#endif /* AVCODEC_ARM_ASM_OFFSETS_H */
|