Update pull_request.yml

This commit is contained in:
Stef Tervelde
2025-01-10 17:44:19 +01:00
committed by GitHub
parent df36fd0e3d
commit 260a7cd84d
+4 -9
View File
@@ -52,7 +52,9 @@ jobs:
- name: Setup Ant
uses: cedx/setup-ant@v3
- name: Install Certificates for Code Signing
if: ${{ matrix.os_prefix == 'macos' }}
env:
cert_secret: ${{ secrets.CERTIFICATES_P12 }}
if: ${{ matrix.os_prefix == 'macos' && secrets.CERTIFICATES_P12 != '' }}
uses: apple-actions/import-codesign-certs@v3
with:
p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
@@ -60,7 +62,7 @@ jobs:
- name: Build Release
run: ant -noinput -buildfile build/build.xml ${{ matrix.os_prefix }}-dist -Dversion="${{ github.sha }}"
env:
PROCESSING_APP_SIGNING: true
PROCESSING_APP_SIGNING: secrets.CERTIFICATES_P12 != ''
- name: Add artifact
uses: actions/upload-artifact@v3
id: upload
@@ -68,10 +70,3 @@ jobs:
name: processing-${{github.sha}}${{ matrix.os_prefix }}-${{ matrix.arch }}
path: ./build/${{ matrix.os_prefix }}/processing-${{github.sha}}-${{ matrix.os_prefix}}-*
retention-days: 5
# TODO: Merge into one comment and fix the link
# - uses: mshick/add-pr-comment@v2
# with:
# message-id: "build-artifact ${{ matrix.os_prefix }} ${{ matrix.arch }}"
# message: |
# Build artifacts for ${{ matrix.os_prefix }} (${{ matrix.arch }}) have been created.
# Download the artifacts [here](${{ steps.upload.outputs.artifact-id }}).