Merge pull request #4920 from gohai/pgl-validateframebuffer

Report more error conditions in validateFramebuffer
This commit is contained in:
Gottfried Haider
2017-02-19 02:28:48 +01:00
committed by GitHub
2 changed files with 23 additions and 1 deletions
+19 -1
View File
@@ -2052,6 +2052,9 @@ public abstract class PGL {
int status = checkFramebufferStatus(FRAMEBUFFER);
if (status == FRAMEBUFFER_COMPLETE) {
return true;
} else if (status == FRAMEBUFFER_UNDEFINED) {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"framebuffer undefined"));
} else if (status == FRAMEBUFFER_INCOMPLETE_ATTACHMENT) {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"incomplete attachment"));
@@ -2064,12 +2067,24 @@ public abstract class PGL {
} else if (status == FRAMEBUFFER_INCOMPLETE_FORMATS) {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"incomplete formats"));
} else if (status == FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER) {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"incomplete draw buffer"));
} else if (status == FRAMEBUFFER_INCOMPLETE_READ_BUFFER) {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"incomplete read buffer"));
} else if (status == FRAMEBUFFER_UNSUPPORTED) {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"framebuffer unsupported"));
} else if (status == FRAMEBUFFER_INCOMPLETE_MULTISAMPLE) {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"incomplete multisample buffer"));
} else if (status == FRAMEBUFFER_INCOMPLETE_LAYER_TARGETS) {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"incomplete layer targets"));
} else {
System.err.println(String.format(FRAMEBUFFER_ERROR,
"unknown error"));
"unknown error " + status));
}
return false;
}
@@ -2985,6 +3000,7 @@ public abstract class PGL {
public static int DEPTH_STENCIL;
public static int FRAMEBUFFER_COMPLETE;
public static int FRAMEBUFFER_UNDEFINED;
public static int FRAMEBUFFER_INCOMPLETE_ATTACHMENT;
public static int FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT;
public static int FRAMEBUFFER_INCOMPLETE_DIMENSIONS;
@@ -2992,6 +3008,8 @@ public abstract class PGL {
public static int FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER;
public static int FRAMEBUFFER_INCOMPLETE_READ_BUFFER;
public static int FRAMEBUFFER_UNSUPPORTED;
public static int FRAMEBUFFER_INCOMPLETE_MULTISAMPLE;
public static int FRAMEBUFFER_INCOMPLETE_LAYER_TARGETS;
public static int FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE;
public static int FRAMEBUFFER_ATTACHMENT_OBJECT_NAME;
+4
View File
@@ -45,6 +45,7 @@ import com.jogamp.opengl.GL2ES2;
import com.jogamp.opengl.GL2ES3;
import com.jogamp.opengl.GL2GL3;
import com.jogamp.opengl.GL3ES3;
import com.jogamp.opengl.GL3;
import com.jogamp.opengl.GLAutoDrawable;
import com.jogamp.opengl.GLCapabilities;
import com.jogamp.opengl.GLCapabilitiesImmutable;
@@ -976,6 +977,7 @@ public class PJOGL extends PGL {
DEPTH_STENCIL = GL.GL_DEPTH_STENCIL;
FRAMEBUFFER_COMPLETE = GL.GL_FRAMEBUFFER_COMPLETE;
FRAMEBUFFER_UNDEFINED = GL3.GL_FRAMEBUFFER_UNDEFINED;
FRAMEBUFFER_INCOMPLETE_ATTACHMENT = GL.GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT;
FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT = GL.GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT;
FRAMEBUFFER_INCOMPLETE_DIMENSIONS = GL.GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS;
@@ -983,6 +985,8 @@ public class PJOGL extends PGL {
FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER = GL2GL3.GL_FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER;
FRAMEBUFFER_INCOMPLETE_READ_BUFFER = GL2GL3.GL_FRAMEBUFFER_INCOMPLETE_READ_BUFFER;
FRAMEBUFFER_UNSUPPORTED = GL.GL_FRAMEBUFFER_UNSUPPORTED;
FRAMEBUFFER_INCOMPLETE_MULTISAMPLE = GL.GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE;
FRAMEBUFFER_INCOMPLETE_LAYER_TARGETS = GL3.GL_FRAMEBUFFER_INCOMPLETE_LAYER_TARGETS;
FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE = GL.GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE;
FRAMEBUFFER_ATTACHMENT_OBJECT_NAME = GL.GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME;