cleaning up how incompatible Tools, etc are handled

This commit is contained in:
Ben Fry
2020-09-24 18:57:57 -04:00
parent 5a115ccdd1
commit 73d65e9343
2 changed files with 17 additions and 22 deletions

View File

@@ -742,9 +742,10 @@ public class Base {
// isn't completely set up yet. Also not gonna pop up a warning because
// people may still be running different versions of Processing.
} catch (VerifyError ve) {
} catch (VerifyError | AbstractMethodError ve) {
System.err.println("\"" + tool.getMenuTitle() + "\" is not " +
"compatible with this version of Processing");
Messages.loge("Incompatible Tool found during tool.init()", ve);
} catch (NoSuchMethodError nsme) {
System.err.println("\"" + tool.getMenuTitle() + "\" is not " +
@@ -758,18 +759,9 @@ public class Base {
System.err.println("The " + ncdfe.getMessage() + " class is no longer available.");
Messages.loge("Incompatible Tool found during tool.init()", ncdfe);
} catch (AbstractMethodError ame) {
System.err.println("\"" + tool.getMenuTitle() + "\" is not " +
"compatible with this version of Processing");
// ame.printStackTrace();
} catch (Error err) {
} catch (Error | Exception e) {
System.err.println("An error occurred inside \"" + tool.getMenuTitle() + "\"");
err.printStackTrace();
} catch (Exception ex) {
System.err.println("An exception occurred inside \"" + tool.getMenuTitle() + "\"");
ex.printStackTrace();
e.printStackTrace();
}
}
}
@@ -894,11 +886,11 @@ public class Base {
try {
tool.run();
} catch (NoSuchMethodError nsme) {
activeEditor.statusError("\"" + tool.getMenuTitle() + "\" is not" +
"compatible with this version of Processing");
//nsme.printStackTrace();
Messages.loge("Incompatible tool found during tool.run()", nsme);
} catch (NoSuchMethodError | java.lang.NoClassDefFoundError ne) {
Messages.showWarning("Tool out of date",
tool.getMenuTitle() + " is not compatible with this version of Processing.\n" +
"Try updating the Mode or contact its author for a new version.", ne);
Messages.loge("Incompatible tool found during tool.run()", ne);
item.setEnabled(false);
} catch (Exception ex) {

View File

@@ -7,6 +7,8 @@ X audio and video broken on macOS b/c can't access mic/camera
X https://github.com/processing/processing-sound/issues/51
X 'ant source-jar' target added to core
X https://github.com/processing/processing4/issues/118
X show Tool incompatibilities with a message dialog
X clean up a little of the internal error handling there
contribs
@@ -28,12 +30,18 @@ _ JSSC binaries for windows_32 and windows_64 appear to be macOS files
_ https://github.com/processing/processing4/issues/119
_ Move PdePreprocessIssueException to the test package
_ https://github.com/processing/processing4/issues/130
_ can we get rid of pdexEnabled? does it work w/ java tabs?
discuss with Andres
_ Add language support to modes
_ https://github.com/processing/processing4/pull/14
roadmap
_ Java 17 is the next LTS, arriving in September 2021
already fixed in 4.x? (confirm/close on release)
_ HDPI support GNOME desktop
_ https://github.com/processing/processing/issues/6059
@@ -99,11 +107,6 @@ _ Switch to getModifiersEx() in `processing.app`
_ https://github.com/processing/processing4/issues/67
questions
_ can we get rid of pdexEnabled? does it work w/ java tabs?
_ Java 17 is the next LTS, arriving in September 2021
_ language server refactoring
_ https://github.com/processing/processing4/issues/117
_ https://theia-ide.org/