final fixes for 0082, full merge of simon's code

app/PdeEditor.java

@@ -253,7 +253,7 @@ public class PdeEditor extends JFrame
     // figure out window placement
 
     Dimension screen = Toolkit.getDefaultToolkit().getScreenSize();
-    boolean windowPositionInvalid = false;
+    boolean windowPositionValid = true;
 
     if (PdePreferences.get("last.screen.height") != null) {
       // if screen size has changed, the window coordinates no longer
@@ -262,13 +262,20 @@ public class PdeEditor extends JFrame
       int screenH = PdePreferences.getInteger("last.screen.height");
 
       if ((screen.width != screenW) || (screen.height != screenH)) {
-        windowPositionInvalid = true;
+        windowPositionValid = false;
       }
+      int windowX = PdePreferences.getInteger("last.window.x");
+      int windowY = PdePreferences.getInteger("last.window.y");
+      if ((windowX < 0) || (windowY < 0) ||
+          (windowX > screenW) || (windowY > screenH)) {
+        windowPositionValid = false;
+      }
+
     } else {
-      windowPositionInvalid = true;
+      windowPositionValid = false;
     }
 
-    if (windowPositionInvalid) {
+    if (!windowPositionValid) {
       //System.out.println("using default size");
       int windowH = PdePreferences.getInteger("default.window.height");
       int windowW = PdePreferences.getInteger("default.window.width");

build/shared/lib/preferences.txt

@@ -46,7 +46,7 @@ settings.path.fallback=data
 
 # default size for the main window
 default.window.width = 500
-default.window.height = 500
+default.window.height = 600
 
 # font size for editor
 editor.font=Monospaced,plain,12

build/shared/revisions.txt

@@ -7,6 +7,46 @@ releases will be super crusty.
 . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 
 
 
+ABOUT REV 0082 - 6 april 2005
+
+- default lighting now works.. lights() and noLights() should properly
+  make things look 3D and pretty... this is all thanks to simon. there 
+  are a ton of features that come along with this, but we're testing
+  them and finalizing the api first before announcing them.
+
+- the stop button should be working again
+
+- default window height is no longer insufficient (after prefs were
+  deleted on windows, on the next run the window was smashed)
+
+- "sto" is now "stop" while in present mode
+
+- it looks as though the opengl libraries weren't properly added in
+  the last release. no more.
+
+- added an extra requestFocus() for opengl
+
+- added ryan's grow box design for osx
+
+
+known problems
+
+- P2D still badly broken
+
+- dragging the applet window around will usually halt it (especially
+  with opengl)
+
+- println() is super slow
+
+- moving the main p5 window to another screen just gets thrown out, 
+  to prevent a case where a second display is unplugged. this will 
+  change in a future release to properly record its previous position
+  and what monitor it was on.
+
+
+. . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 
+
+
 ABOUT REV 0081 - 4 april 2005
 
 * major api changes in this release *

core/PApplet.java

@@ -4852,7 +4852,6 @@ v              PApplet.this.stop();
       }
 
       //System.out.println("showing frame");
-
       //System.out.println("applet requesting focus");
       applet.requestFocus(); // ask for keydowns
       //System.out.println("exiting main()");

core/todo.txt

@@ -3,9 +3,16 @@ X make jdkVersion, jdkVersionName, platform, platformName variables
 X additional note about screen sizes and displays
 X sto instead of stop in present mode
 X appears that opengl libraries weren't correctly added in 81?
+X requestFocus() now called on gl canvas
 
 _ fix bezierVertex() for newer api
 
+_ set(x, y, image)
+_   x, y not setting with processing
+_   y reversed in openGL 
+
+_ fix messages referring to depth()
+
 tweaking up simong light code
 _ why does diffuse just mirror fill()?
 X   just removed it
@@ -48,6 +55,15 @@ _ make illustrator lib
 
 _ move really general things out of PConstants (X, Y, Z..)
 
+sound
+_ When a sound is finished playing, it should return to 0 so it can play again
+_ Putting sound.loop() in draw() seemed to spawn multiple sounds threads?
+_ After a sound is paused, it will only play from where it was paused
+_   to its end and will not loop again
+_ The ref in PSound2 says volume accepts vals from 0...1
+_   but values larger than one increase the volume.
+_ SoundEvent // is sound finished?? Can't access now. 
+
 
 . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 
 

opengl/PGraphicsGL.java

@@ -135,6 +135,9 @@ public class PGraphicsGL extends PGraphics3 {
       // updates.
       canvas.setNoAutoRedrawMode(true);
 
+      // maybe this will help?
+      canvas.requestFocus();
+
       // done with this business
       displayed = true;
     }

todo.txt

@@ -6,6 +6,11 @@ o   this is both for PApplet and PdeRuntime
 o   PApplet screen size constant is no good
 X   nope, because centers on default screen
 X external apps don't stop at all when 'stop' is hit
+o revisions.txt et al aren't properly having LFs converted
+X   false alarm, was only on rev 69
+X set default window height to 600 so that it appears properly
+X   windows version was smashing it at the bottom when new prefs
+X don't allow saved window position to be outside the current display
 
 _ moving an external window around a lot will halt the parent
 _   does move even need to be called? could just wait till stop?
@@ -64,7 +69,12 @@ _   lib could call queueEvent with the args
 _   then call them inside post()
 _ scrubbing all the code to include proper license and copyright info
 
-_ revisions.txt et al aren't properly having LFs converted
+Not sure what triggers it, possibly scrolling with mousewheel?, but
+sometimes Processing output window gets stuck thinking it should
+scroll to the top, so if you have an output larger than the allowable
+space, it will show you the last line, but then pops the scrollbar
+back to the top.  I think the only way to stop it is to quit out of
+processing and relaunch. 
 
 _ update checker (can be turned off in prefs)
 _   send unique id, and information about person's java vm/platform