fixes for alpha issues

core/src/processing/core/PGraphicsJava2D.java

@@ -1447,8 +1447,16 @@ public class PGraphicsJava2D extends PGraphics {
 //          op.filter(image, image);
         }
       } else {  // !tint
+        if (targetType == RGB && (source.pixels[0] >> 24 == 0)) {
+          // If it's an RGB image and the high bits aren't set, need to set
+          // the high bits to opaque because we're drawing ARGB images.
+          source.filter(OPAQUE);
+          // Opting to just manipulate the image here, since it shouldn't
+          // affect anything else (and alpha(get(x, y)) should return 0xff).
+          // Wel also make no guarantees about the values of the pixels array
+          // in a PImage and how the high bits will be set.
+        }
         // If no tint, just shove the pixels on in there verbatim
-//        System.out.println("!tint source.pixels[0] alpha is " + (source.pixels[0] >>> 24));
         wr.setDataElements(0, 0, source.width, source.height, source.pixels);
       }
       this.tinted = tint;

core/todo.txt

@@ -1,4 +1,10 @@
 0224 core
+X PImage resize() causes PImage not to be rendered in JAVA2D
+X   https://github.com/processing/processing/issues/2179
+
+fixed in 2.1
+X draw() called again before finishing on OS X (retina issue)
+X   https://github.com/processing/processing/issues/1709
 
 
 high
@@ -16,8 +22,6 @@ _   display=all in cmd line
 _   sketchDisplay() -> 0 for all, or 1, 2, 3...
 _ test PGraphicsRetina2D w/ 7u40 
 _ make sure that 7u40 doesn't reintroduce starvation issue on retina Macs
-_ draw() called again before finishing on OS X (retina issue)
-_   https://github.com/processing/processing/issues/1709
 _ Linux sometimes not responding correctly w/ the size() command
 _   https://github.com/processing/processing/issues/1672
 _ clean up requestFocus() stuff

done.txt

@@ -28,6 +28,7 @@ X   looks like issue that was covered in 2.0.3 changes
 X non-compliant libraries cause crash on "Add Library"
 X   https://github.com/processing/processing/issues/2026
 X Open new PDE maximized when current PDE is maximized
+X   https://github.com/processing/processing/issues/1984
 X   https://github.com/processing/processing/pull/2037
 X incorporate the new serial library
 X   https://github.com/processing/processing/pull/2093

todo.txt

@@ -1,4 +1,19 @@
 0224 pde
+X readStringUntil() missing from new serial library
+X   https://github.com/processing/processing/issues/2174
+
+fixed in 2.1
+X init() not called on tools until later 
+X   https://github.com/processing/processing/issues/1859
+X Finish changes so the PDE can use an unmodified JRE
+X   https://github.com/processing/processing/issues/1840
+
+
+high
+_ adding characters doesn't happen on position of cursor
+_   https://github.com/processing/processing/issues/2180
+_ Chinese text is overlapped in Processing 2.1 editor
+_   https://github.com/processing/processing/issues/2173
 
 
 medium
@@ -527,8 +542,6 @@ _ classpath conflicts..
 _   getPackageList.. from Library... maybe others?
 _   really need to make sure that a weird core.jar isn't being imported
 _   coffeescript was doing this and breaking the pde
-_ init() not called on tools until later 
-_   https://github.com/processing/processing/issues/1859
 _ contrib library examples are not read-only
 _   another point for doing .zip files to prevent overwriting
 _ add BookContribution?