remove delete prev sketch folder pref, more cleanup

app/src/processing/app/Mode.java

@@ -815,7 +815,7 @@ public abstract class Mode {
    */
   public void prepareExportFolder(File targetFolder) {
     if (targetFolder != null) {
-      // Nuke the old applet/application folder because it can cause trouble
+      // Nuke the old application folder because it can cause trouble
       if (Preferences.getBoolean("export.delete_target_folder")) {
         if (targetFolder.exists()) {
           try {

app/src/processing/app/ui/PreferencesFrame.java

@@ -56,7 +56,7 @@ public class PreferencesFrame {
   JTextField sketchbookLocationField;
   JTextField presentColor;
   //JCheckBox editorAntialiasBox;
-  JCheckBox deletePreviousBox;
+//  JCheckBox deletePreviousBox;
   JCheckBox memoryOverrideBox;
   JTextField memoryField;
   JCheckBox checkUpdatesBox;
@@ -385,8 +385,8 @@ public class PreferencesFrame {
 
     // [ ] Delete previous application folder on export
 
-    deletePreviousBox =
-      new JCheckBox(Language.text("preferences.delete_previous_folder_on_export"));
+//    deletePreviousBox =
+//      new JCheckBox(Language.text("preferences.delete_previous_folder_on_export"));
 
 
     // [ ] Check for updates on startup
@@ -524,7 +524,7 @@ public class PreferencesFrame {
 
     //
 
-    addRow(axis, deletePreviousBox);
+//    addRow(axis, deletePreviousBox);
     addRow(axis, checkUpdatesBox);
     addRow(axis, syncSketchNameBox);
 
@@ -655,8 +655,8 @@ public class PreferencesFrame {
 //    Preferences.setBoolean("editor.smooth", //$NON-NLS-1$
 //                           editorAntialiasBox.isSelected());
 
-    Preferences.setBoolean("export.delete_target_folder", //$NON-NLS-1$
-                           deletePreviousBox.isSelected());
+//    Preferences.setBoolean("export.delete_target_folder", //$NON-NLS-1$
+//                           deletePreviousBox.isSelected());
 
     // if the sketchbook path has changed, rebuild the menus
     String oldPath = Preferences.getSketchbookPath();
@@ -801,7 +801,7 @@ public class PreferencesFrame {
     warningsCheckerBox.setEnabled(errorCheckerBox.isSelected());
     codeCompletionBox.setSelected(Preferences.getBoolean("pdex.completion"));
     importSuggestionsBox.setSelected(Preferences.getBoolean("pdex.suggest.imports"));
-    deletePreviousBox.setSelected(Preferences.getBoolean("export.delete_target_folder")); //$NON-NLS-1$
+//    deletePreviousBox.setSelected(Preferences.getBoolean("export.delete_target_folder")); //$NON-NLS-1$
 
     sketchbookLocationField.setText(Preferences.getSketchbookPath());
     checkUpdatesBox.setSelected(Preferences.getBoolean("update.check")); //$NON-NLS-1$

build/shared/lib/defaults.txt

@@ -258,7 +258,8 @@ export.application.stop = true
 # embed Java by default for lower likelihood of problems
 export.application.embed_java = true
 
-# set to false to no longer delete applet or application folders before export
+# set to false to no longer delete application folders before export
+# (removed from the Preferences windows in 4.0 beta 9)
 export.delete_target_folder = true
 
 # may be useful when attempting to debug the preprocessor

build/shared/lib/languages/PDE.properties

@@ -208,7 +208,7 @@ preferences.trigger_with = Trigger with
 preferences.cmd_space = space
 preferences.suggest_imports = Suggest import statements
 preferences.increase_max_memory = Increase maximum available memory to
-preferences.delete_previous_folder_on_export = Delete previous folder on export
+# preferences.delete_previous_folder_on_export = Delete previous folder on export
 preferences.check_for_updates_on_startup = Allow update checking (see FAQ for information shared)
 preferences.run_sketches_on_display = Run sketches on display
 preferences.run_sketches_on_display.tip = Sets the display where sketches are initially placed.<br>As usual, if the sketch window is moved, it will re-open<br>at the same location, however when running in present<br>(full screen) mode, this display will always be used.

todo.txt

@@ -36,6 +36,7 @@ X icons for contrib manager list entries (green/orange PNGs won't do)
 X remove ability to rearrange columns in contrib manager
 X   why tf this is the default is beyond me
 X remove extra space between prefs lines
+_ Export to Application fonts are too tiny
 
 
 design/manager
@@ -51,7 +52,7 @@ _ progress bar in contrib manager
 
 design/manager/waiting
 X need monochrome icon for foundation
-_ do we need other states for list item icons
+_ do we need other color states for list item icons
 _ update lib/theme.txt to clean up current Frankenstein status
 _   just replace with the blue default once that's updated
 
@@ -91,17 +92,21 @@ X   becomes preferecnes.restart_required = Restart Processing to apply changes
 X put language & complex text on same line
 X move colons into the language file
 X show hand cursor with links for labels
-
-_ finish rearranging item order in PreferencesFrame
-_ move to separate panel
-_   (maybe not, because not clear which will be inherited by other modes?)
-_   background when presenting
-_   continuously check
-_   code completion
-_   suggest imports
-_   increase memory
-_ move delete previous pref to the Export to Application window
-_   get rid of the pref/just use the setting from export to app
+o move delete previous pref to the Export to Application window
+o   get rid of the pref/just use the setting from export to app
+X   no clear alternative for disabling this, so remove from prefs window
+X     but still supported inside preferences.txt for those who must
+X     it's moving the files to the trash anyway, which should be safe enough
+X finish rearranging item order in PreferencesFrame
+X   all set for now
+o move to separate panel
+o   (maybe not, because not clear which will be inherited by other modes?)
+o   background when presenting
+o   continuously check
+o   code completion
+o   suggest imports
+o   increase memory
+X   opting not to: not enough items, and too disruptive for unclear benefit
 
 contrib
 X Double-clicking a .pde file also opens an untitled/empty sketch