eessppeelllloo/processing4
1
0
Fork 0
mirror of https://github.com/processing/processing4.git synced 2026-06-16 04:26:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix for bug #774 to improve tessellation

Browse Source
This commit is contained in:
benfry
2008-05-30 17:54:24 +00:00
parent 2445eabf9d
commit e531f342e3
4 changed files with 27 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
build/shared/revisions.txt
+17
View File
@@ -7,6 +7,23 @@ releases will be super crusty.
. . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
ABOUT REV 0138 - ?? ???? 2008
[ bug fixes ]
+ Fix tessellation problems with concave 3D geometry that has many
nearby points (e.g. filled bezier polygons like fonts).
Upgrade values to doubles, and multiply by 10 so that we can have
some better accuracy as we tessellate. This seems to have negligible
speed differences on Windows and Intel Macs, but causes a 50% speed
drop for PPC Macs with the bug's example code that draws ~200 points
in a concave polygon. Apple has abandoned PPC so we may as well too.
http://dev.processing.org/bugs/show_bug.cgi?id=774
. . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
ABOUT REV 0137 - 30 May 2008
This release is an addendum to 0136, please read the notes on that
core/src/processing/core/PGraphics3D.java
+7 -31
View File
@@ -1691,15 +1691,14 @@ public class PGraphics3D extends PGraphics {
v = u + 1; if (vc <= v) v = 0; // current
int w = v + 1; if (vc <= w) w = 0; // next
// Upgrade values to doubles, and multiply by 10 so that we can have
// some better accuracy as we tessellate. This seems to have negligible
// speed differences on Windows and Intel Macs, but causes a 50% speed
// drop for PPC Macs with the bug's example code that draws ~200 points
// in a concave polygon. Apple has abandoned PPC so we may as well too.
// http://dev.processing.org/bugs/show_bug.cgi?id=774
// triangle A B C
/*
float Ax = -vertices[vertex_order[u]][d1];
float Ay = vertices[vertex_order[u]][d2];
float Bx = -vertices[vertex_order[v]][d1];
float By = vertices[vertex_order[v]][d2];
float Cx = -vertices[vertex_order[w]][d1];
float Cy = vertices[vertex_order[w]][d2];
*/
double Ax = -10 * vertices[vertex_order[u]][d1];
double Ay = 10 * vertices[vertex_order[u]][d2];
double Bx = -10 * vertices[vertex_order[v]][d1];
@@ -1707,9 +1706,6 @@ public class PGraphics3D extends PGraphics {
double Cx = -10 * vertices[vertex_order[w]][d1];
double Cy = 10 * vertices[vertex_order[w]][d2];
// 4235.0 on 0135, 5894.0 with this
//double E10 = EPSILON * 10;
// first we check if <u,v,w> continues going ccw
if (EPSILON > (((Bx-Ax) * (Cy-Ay)) - ((By-Ay) * (Cx-Ax)))) {
continue;
@@ -1737,26 +1733,6 @@ public class PGraphics3D extends PGraphics {
if ((aCROSSbp >= 0.0) && (bCROSScp >= 0.0) && (cCROSSap >= 0.0)) {
snip = false;
}
/*
float Px = -vertices[vertex_order[p]][d1];
float Py = vertices[vertex_order[p]][d2];
float ax = Cx - Bx; float ay = Cy - By;
float bx = Ax - Cx; float by = Ay - Cy;
float cx = Bx - Ax; float cy = By - Ay;
float apx = Px - Ax; float apy = Py - Ay;
float bpx = Px - Bx; float bpy = Py - By;
float cpx = Px - Cx; float cpy = Py - Cy;
float aCROSSbp = ax * bpy - ay * bpx;
float cCROSSap = cx * apy - cy * apx;
float bCROSScp = bx * cpy - by * cpx;
if ((aCROSSbp >= 0.0f) && (bCROSScp >= 0.0f) && (cCROSSap >= 0.0f)) {
snip = false;
}
*/
}
if (snip) {
core/todo.txt
+2 -1
View File
@@ -1,5 +1,6 @@
0138 core
X improve tessellation accuracy by using doubles internally
X http://dev.processing.org/bugs/show_bug.cgi?id=774
_ Add support style attribute for path tag to Candy SVG (ricard)
_ http://dev.processing.org/bugs/show_bug.cgi?id=771
todo.txt
+1
View File
@@ -6,6 +6,7 @@ _ (in particular while cpu load is a little higher on g5?)
_ http://dev.processing.org/bugs/show_bug.cgi?id=775
_ this may just be a macosx (ppc?) bug
_ seems on some machines to just never launch at all
_ only happens with windows that aren't the original/main window
_ two-tiered dialogs for everything - use big font/little font style throughout